Fix Python 3.14 dict iteration error in JsonModel#764
Merged
Conversation
In Python 3.14, iterating over cls.__dict__.items() directly can raise RuntimeError: dictionary changed size during iteration. This fix creates a copy of the dictionary before iteration to prevent this error. Fixes #763
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Instead of copying cls.__dict__ to avoid Python 3.14 iteration errors, iterate over cls.__annotations__ keys and look up values individually. This avoids the memory overhead of copying the entire __dict__. Also adds comprehensive tests for schema_for_fields edge cases.
❌ Jit Scanner failed - Our team is investigatingJit Scanner failed - Our team has been notified and is working to resolve the issue. Please contact support if you have any questions. 💡 Need to bypass this check? Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #763 - Python 3.14 compatibility for
JsonModel.schema_for_fields().The Problem
In Python 3.14, iterating over
cls.__dict__.items()directly can raise:This occurs during class construction when Pydantic is still modifying the class namespace.
The Solution
Instead of copying the entire
__dict__before iteration (which wastes memory), this PR iterates overcls.__annotations__keys and looks up each value in__dict__individually:This approach:
__dict__Tests Added
Comprehensive test coverage for
schema_for_fields()edge cases: