Fix inconsistent .pk behaviour with custom primary keys#784
Merged
Conversation
When a model uses a custom primary key field (e.g., x: int = Field(primary_key=True)), accessing .pk now correctly returns the actual value instead of an ExpressionProxy. Adds PrimaryKeyAccessor descriptor that redirects .pk access to the custom primary key field value while preserving ExpressionProxy for class-level query building. Fixes #570
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #570 - When using a custom primary key field (e.g.,
x: int = Field(primary_key=True)), accessing.pkon an instance now correctly returns the actual value instead of anExpressionProxyor auto-generated ULID.Changes
Added
PrimaryKeyAccessordescriptor class that:ExpressionProxyfor class-level access (query building)Modified
ModelMeta.__new__to:pk)pkfield frommodel_fieldsPrimaryKeyAccessordescriptor for.pkaccessUpdated
validate_primary_key()to safely handle cases wherepkwas already removedExample
Testing