[CORE-9879] kafka: Support for metadata v12#26235
Closed
BenPope wants to merge 5 commits intoredpanda-data:devfrom
Closed
[CORE-9879] kafka: Support for metadata v12#26235BenPope wants to merge 5 commits intoredpanda-data:devfrom
BenPope wants to merge 5 commits intoredpanda-data:devfrom
Conversation
Collaborator
Retry command for Build#66372please wait until all jobs are finished before running the slash command |
Collaborator
CI test resultstest results on build#66372
|
Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
force-pushed
the
CORE-9879/metadata_v12
branch
from
a4bd672 to
f282865
Compare
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Add back testing that was previously removed. Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
force-pushed
the
CORE-9879/metadata_v12
branch
from
f282865 to
d2f616e
Compare
Member
Author
|
Changes in force-push
Changes in force-push
|
IoannisRP
reviewed
Jul 21, 2025
Comment on lines
99
to
+102
| class uuid { | ||
| public: | ||
| static constexpr auto length = 16; | ||
| using underlying_t = std::array<uint8_t, length>; | ||
| using underlying_t = uuid_t; |
Contributor
There was a problem hiding this comment.
Is it for historic reasons that we have both kafka::uuid and uuid_t types? or is there a reason to redefine the type here? The only difference i see is that there are no non-const accessors.
Either way, length can be removed (or be defined in terms of uuid_t::length).
Comment on lines
+320
to
+324
| const bool should_describe | ||
| = (!use_topic_ids && topic.name.has_value()) | ||
| || (use_topic_ids && topic.topic_id != uuid{}); | ||
|
|
||
| if (use_topic_ids && topic.topic_id != uuid{}) { |
Contributor
There was a problem hiding this comment.
repeated use of use_topic_ids && topic.topic_id != uuid{}. Better to extract it to a named variable
Comment on lines
+364
to
+372
| if (!use_topic_ids) { | ||
| bool valid = topic.name.has_value() | ||
| && validate_kafka_topic_name(*topic.name) | ||
| == model::errc::success; | ||
| res.push_back(make_error_topic_response( | ||
| move_topic_name(), | ||
| valid ? error_code::unknown_topic_or_partition | ||
| : error_code::invalid_topic_exception)); | ||
| } |
Contributor
There was a problem hiding this comment.
previously, this conditional would always push back to res. Now we push back to res only if !use_topic_ids, but we continue, regardless.
Is this the desired behavior?
Member
Author
There was a problem hiding this comment.
previously, this conditional would always push back to
res. Now we push back toresonly if!use_topic_ids, but wecontinue, regardless.Is this the desired behavior?
It might be useful to more closely model the code layout in kafka, but yes: https://github.com/apache/kafka/blob/4.0.0/core/src/main/scala/kafka/server/KafkaApis.scala#L860-L861
Comment on lines
+354
to
+356
| auto topic_id = get_topic_id(test_topic_name); | ||
| BOOST_REQUIRE(topic_id.has_value()); | ||
| BOOST_REQUIRE_NE(topic_id.value(), model::topic_id{}); |
Contributor
There was a problem hiding this comment.
does this needs to be inside the loop?
| .get(); | ||
| BOOST_REQUIRE(!create_resp.data.errored()); | ||
|
|
||
| const kafka::metadata_response_data default_response; |
Comment on lines
+479
to
+480
| .topics | ||
| = {{{.name{ssx::sformat("{}_{}_{}", test_topic_create, "by_name", ver)}}, {.name{test_topic_query}}}}, |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| .topics | |
| = {{{.name{ssx::sformat("{}_{}_{}", test_topic_create, "by_name", ver)}}, {.name{test_topic_query}}}}, | |
| .topics{ | |
| {{.name{ | |
| ssx::sformat("{}_{}_{}", test_topic_create, "by_name", ver)}}, | |
| {.name{test_topic_query}}}}, |
Removing the = produces much more readable formating.
The rest of the values (bools) give a warning without the =, so i say mix them.
Comment on lines
+498
to
+499
| .topics | ||
| = {{{.name{ssx::sformat("{}_{}_{}", test_topic_create, "by_id", ver)}}, {.topic_id{kafka::uuid{*query_topic_id}}}}}, |
|
|
||
| @cluster(num_nodes=3, log_allow_list=TX_ERROR_LOGS) | ||
| @matrix(version=["2.1.0"]) | ||
| @matrix(version=["2.1.0", "2.6.0"]) |
Contributor
There was a problem hiding this comment.
Previously we had these with metadata v11. Now they are added back together with v12.
Would it be possible to add a comment on the commit as to what requirements it has/how it is connected to the rest of the changes?
8 tasks
Member
Author
|
Moving to closed, in favour of #26968 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for metadata v12
Backports Required
Release Notes