[CORE-9880]: Preperation for Topic Identifiers#27249
Merged
BenPope merged 12 commits intoredpanda-data:devfrom Aug 15, 2025
Merged
[CORE-9880]: Preperation for Topic Identifiers#27249BenPope merged 12 commits intoredpanda-data:devfrom
BenPope merged 12 commits intoredpanda-data:devfrom
Conversation
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
8 tasks
Collaborator
CI test resultstest results on build#70811
|
Member
Author
|
That test wasn't supposed to fail, this PR makes no functional changes. |
pgellert
previously approved these changes
Aug 15, 2025
Contributor
pgellert
left a comment
pgellert
left a comment
There was a problem hiding this comment.
Looks good. I'm approving because none of my comments are blocking, but it would be good to get them addressed either in this PR or carried over to a subsequent PR.
Comment on lines
+57
to
+65
| const auto no_id = topic_id{}; | ||
| if (lhs._id == no_id || rhs._id == no_id) { | ||
| return lhs._tp_view == rhs._tp_view; | ||
| } | ||
| return std::tie(lhs._id, lhs._tp_view) | ||
| == std::tie(rhs._id, rhs._tp_view); |
Contributor
There was a problem hiding this comment.
It is not yet clear to me if this is the specific behaviour we want in all of the uses cases of a topic id + ntp pair. It very well might be, so I'm happy to merge this as is. I am just making a mental note here that I should pay attention to kitp comparisons in later commits/PRs to confirm that this behaviour makes sense in all of the use cases.
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Prefer `uuid_t` and `model::topic_id`. Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
force-pushed
the
core-9880/kafka_fetch_v13_prep
branch
from
740ff5e to
c7a81d4
Compare
Member
Author
|
changes in force-push
|
pgellert
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates and rebase of some of the commits in: #26968
Backports Required
Release Notes