[CORE-13570] Deflake test_timequery_with_local_gc
#28070
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -59,6 +59,8 @@ def _create_and_produce( | |||||
| "redpanda.remote.read": "true", | ||||||
| "redpanda.remote.write": "true", | ||||||
| "retention.local.target.bytes": local_retention, | ||||||
| # See comment about disabling `retention.ms` below. | ||||||
| "retention.local.target.ms": -1, | ||||||
| }.items(): | ||||||
| self.client().alter_topic_config(topic.name, k, v) | ||||||
| desc = self.client().describe_topic_configs(topic.name) | ||||||
|
|
@@ -357,6 +359,11 @@ def set_up_cluster(self, cloud_storage: bool, batch_cache: bool, spillover: bool | |||||
| else: | ||||||
| self.redpanda.add_extra_rp_conf({"log_segment_size": self.log_segment_size}) | ||||||
|
|
||||||
| # `test_timequery_with_local_gc` attempts to set the `log_segment_size` lower than the minimum | ||||||
| # value of 1_MiB- disable bounded property checks to allow this. | ||||||
| self.redpanda.set_environment( | ||||||
| {"__REDPANDA_TEST_DISABLE_BOUNDED_PROPERTY_CHECKS": "ON"} | ||||||
| ) | ||||||
|
Comment on lines
+364
to
+366
Member
There was a problem hiding this comment. ahh the warning was on bootup, not from something later like alter topic config. i think the later will fail, but indeed this just seems to warn silently on bootup. |
||||||
| self.redpanda.start() | ||||||
|
|
||||||
| def _do_test_timequery( | ||||||
|
|
@@ -801,7 +808,7 @@ def create_read_replica_topic(self) -> None: | |||||
| } | ||||||
| rpk_rr_cluster.create_topic(self.topic_name, config=conf) | ||||||
| except: | ||||||
| self.logger.warn("Failed to create a read-replica topic") | ||||||
|
Contributor
Author
There was a problem hiding this comment. ruff linter unnecessary
Comment on lines
810
to
+811
There was a problem hiding this comment. Avoid a bare except, which swallows KeyboardInterrupt/SystemExit and makes debugging harder. Catch Exception explicitly and log the exception details. There was a problem hiding this comment. logger.warn is deprecated; use logger.warning instead. Consider including exc_info to capture the exception context.
Suggested change
|
||||||
| return False | ||||||
| return True | ||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inline comment references disabling retention.ms, but the code is setting retention.local.target.ms. Please update the comment to reflect the local retention setting to avoid confusion. For example: 'Disable time-based local retention for tiered storage by setting retention.local.target.ms to -1.'