Migrate useSelector and connect to useMutableSource#1792
Migrate useSelector and connect to useMutableSource#1792wurstbonbon wants to merge 2 commits intoreduxjs:feature/remove-connectadvancedfrom
Conversation
markerikson
changed the base branch from
master
to
feature/remove-connectadvanced
|
Neat, thanks! Good to have something to use as a starting point - appreciate you doing this! It'll be a while before I have time to fully dig through this. My focus atm is on trying to write some additional documentation for the "Redux Essentials" tutorial covering how to use RTK Query. After that I should have time to start thinking more seriously about React-Redux v8. |
wurstbonbon
force-pushed
the
use-mutable-source
branch
from
02a8eb7 to
6d3acbe
Compare
|
FYI, the immediate failure is due to no I'd suggest temporarily committing the tarball directly to this branch and referencing that instead. |
wurstbonbon
force-pushed
the
use-mutable-source
branch
from
6d3acbe to
2204e54
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2204e54:
|
|
✔️ Deploy Preview for react-redux-docs ready! 🔨 Explore the source changes: 2204e54 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/61118703cfc3c70007689888 😎 Browse the preview: https://deploy-preview-1792--react-redux-docs.netlify.app |
|
@markerikson I just figured out the correct URL of package |
|
Well, not sure why the tests didn't run, but at least the size checks passed, which means it built cleanly. Given that this is TS, that's at least a decent first step :) |
markerikson
force-pushed
the
feature/remove-connectadvanced
branch
from
d98c91c to
c7b1bc1
Compare
2 participants
This very rough draft to get the ball rolling and probably too naive. I branched away from
remove-connectadvancedto be closer to the final API. This is meant to be a starting point, feel free to ignore it if it doesn't provide any value. Many tests are failing and some of them hopefully give a hint to where things will become problematic.React testing library does not support React 18 yet and to be able to run the tests one needs to download the package for the PR and install it locally because yarn2 doesn't like URLs without file extension.