fix: preserve keys with undefined values in copyWithStructuralSharing#5274
Open
cyphercodes wants to merge 1 commit into
Open
fix: preserve keys with undefined values in copyWithStructuralSharing#5274cyphercodes wants to merge 1 commit into
undefined values in copyWithStructuralSharing#5274cyphercodes wants to merge 1 commit into
Conversation
Fixes reduxjs#5271 where useLazyQuery's isFetching stayed false when trigger args contained explicit undefined values. The issue was that Object.keys() doesn't include keys with undefined values, causing structural sharing to treat { triggeredAddress: undefined, page: 1 } and { page: 1 } as the same object. Changes: - Use Object.getOwnPropertyNames() instead of Object.keys() to include all keys - Added tests for preserving undefined keys in copyWithStructuralSharing
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
aryaemami59
changed the title
undefined values in copyWithStructuralSharing
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5a87a7a:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5271
Problem
When using
useLazyQuery, if the trigger is called with args that contain explicitundefinedvalues (e.g.{ triggeredAddress: undefined, page: 1 }), the hook'sisFetchingstaysfalseanddatanever updates — even though the network request fires and the returned promise resolves with correct data.Root Cause
copyWithStructuralSharingusedObject.keys()which doesn't include keys withundefinedvalues. This caused{ triggeredAddress: undefined, page: 1 }and{ page: 1 }to be treated as the same object, breaking the hook's ability to track the new cache entry's pending state.Solution
Use
Object.getOwnPropertyNames()instead ofObject.keys()to include all keys, including those withundefinedvalues.Changes
copyWithStructuralSharing.tsto useObject.getOwnPropertyNames()Testing
copyWithStructuralSharingwith undefined values