-
Notifications
You must be signed in to change notification settings - Fork 0
RFC for serialization #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of thoughts on these examples.
The full version is simply refracting the element as a normal object. I believe we would do this anyway within Minim, and would treat it as a normal Object Element.
Regarding the compact example, I don't believe this is a valid array element. I believe it would have to be:
['array', {}, {}, [
['string', {}, {}, 'foo'],
['object', {}, {}, []],
['object', {}, {}, []],
['number', {}, {}, 0]
]]We would still do this in any situations where Compact Refract was not expected I believe.
So I actually believe, without any domain-specific knowledge, we will actually already do as you've defined. The difficulty is knowing where that domain-specific knowledge is in the tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to also explore how we could tell the parse that these are actual elements. We've talked about a few options here, but just wanted to make this comment. :)
|
@danielgtaylor I've added some thoughts. I'd also like to think about this comment where we use your work on the compact version and the RFC for the embedded and create separate repositories for each. We would then remove the compact version from the base Refract spec. |
Move compact to its own repo: refractproject/rfcs#17 Remove namespacing: refractproject/rfcs#22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which serialization formats are these ambiguous in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielgtaylor Will this be resolved with this?
If so, would you care to update this RFC accordingly?
|
How do you all feel about pulling the compact version out of the base spec? I'm not proposing we get rid of it, but I'm wondering if people need to implement it in order to fulfill the base Refract spec. Thoughts? Compact Refract is only mentioned in passing in the spec, and is not explained in detail (like this RFC aims to do). |
Let's remove it from there |
|
See refractproject/refract-spec#53 for moving Compact Refract |
The goal of this RFC is to formalize and document the various serialization formats used by Refract, as well as explicitly list how to handle ambiguity in refracted metadata and attributes.