Skip to content

Comments

fix(log): initialise before first use#529

Merged
JosephKav merged 3 commits intomasterfrom
fix/log--initialise-on-startup
Feb 7, 2025
Merged

fix(log): initialise before first use#529
JosephKav merged 3 commits intomasterfrom
fix/log--initialise-on-startup

Conversation

@JosephKav
Copy link
Collaborator

@JosephKav JosephKav commented Feb 7, 2025

Wasn't initialising the logger before the first possible log.

Builds on #528. (Was keeping the log level at ERROR until after config.Load, meaning the Debug logs of services being initialised were skipped)

@JosephKav JosephKav added the bug Something isn't working label Feb 7, 2025
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (3f15f89) to head (3ba9d74).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
+ Coverage   98.67%   98.67%   +0.01%     
==========================================
  Files         118      119       +1     
  Lines       10314    10332      +18     
==========================================
+ Hits        10176    10194      +18     
  Misses        112      112              
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JosephKav JosephKav merged commit 87d2fcb into master Feb 7, 2025
7 checks passed
@JosephKav JosephKav deleted the fix/log--initialise-on-startup branch February 7, 2025 22:49
@Argus-Bot Argus-Bot mentioned this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant