Skip to content

feat(remix-testing): stablize createRemixStub#7647

Merged
brophdawg11 merged 8 commits into
devfrom
create-remix-stub
Oct 12, 2023
Merged

feat(remix-testing): stablize createRemixStub#7647
brophdawg11 merged 8 commits into
devfrom
create-remix-stub

Conversation

@kentcdodds
Copy link
Copy Markdown
Member

@kentcdodds kentcdodds commented Oct 11, 2023

The Remix stub is ready to go 👍

I've been using it for quite a while and don't have any feedback other than: "it's annoying that it's unstable_" 😅

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 11, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: e06ca02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
remix Minor
@remix-run/testing Minor
create-remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/dev Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kentcdodds
Copy link
Copy Markdown
Member Author

kentcdodds commented Oct 11, 2023

🤦‍♂️ I should've known this would be harder 😅

@kentcdodds
Copy link
Copy Markdown
Member Author

kentcdodds commented Oct 11, 2023

Ok, should be good to go now.

@ryanflorence
Copy link
Copy Markdown
Member

ryanflorence commented Oct 11, 2023

Wrong branch fam

@ryanflorence ryanflorence changed the base branch from main to dev October 11, 2023 18:56
@ryanflorence ryanflorence changed the base branch from dev to main October 11, 2023 19:06
@ryanflorence ryanflorence changed the base branch from main to dev October 11, 2023 19:06
@ryanflorence
Copy link
Copy Markdown
Member

ryanflorence commented Oct 11, 2023 •
edited
Loading

alright, I made a new create-remix-stub branch, cherry picked the three commits from this PR and force pushed to this PR's branch. When it's all green, let's merge.

Thanks Kent! I hope the next few weeks are EPIC!

@brophdawg11
Copy link
Copy Markdown
Contributor

brophdawg11 commented Oct 11, 2023

Thanks! I'm going to take a pass at some quick docs for this so I'll just push them to this PR and then get it merged 👍

@brophdawg11 brophdawg11 self-assigned this Oct 11, 2023
machour
machour reviewed Oct 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

Comment thread docs/utils/create-remix-stub.md Outdated
Comment thread packages/remix-testing/__tests__/stub-test.tsx Outdated
Comment thread packages/remix-testing/create-remix-stub.tsx
brophdawg11 and others added 2 commits October 12, 2023 09:27
@brophdawg11 @machour
Update docs/utils/create-remix-stub.md
e2a1e77 
Co-authored-by: Mehdi Achour <machour@gmail.com>
@brophdawg11 @machour
Update packages/remix-testing/__tests__/stub-test.tsx
e06ca02 
Co-authored-by: Mehdi Achour <machour@gmail.com>
@brophdawg11 brophdawg11 merged commit 2a3ad8c into dev Oct 12, 2023
@brophdawg11 brophdawg11 deleted the create-remix-stub branch October 12, 2023 13:38
@github-actions github-actions Bot added the awaiting release This issue has been fixed and will be released soon label Oct 12, 2023
@github-actions github-actions Bot mentioned this pull request Oct 12, 2023
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 12, 2023

🤖 Hello there,

We just published version 2.1.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey changed the title feat: stablize createRemixStub feat(remix-testing): stablize createRemixStub Oct 15, 2023
@github-actions github-actions Bot mentioned this pull request Oct 16, 2023
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 16, 2023

🤖 Hello there,

We just published version 2.1.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions Bot removed the awaiting release This issue has been fixed and will be released soon label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@machour machour machour left review comments

@ryanflorence ryanflorence ryanflorence approved these changes

@sergiodxa sergiodxa sergiodxa approved these changes

@brophdawg11 brophdawg11 Awaiting requested review from brophdawg11

Assignees

@brophdawg11 brophdawg11

Labels

CLA Signed docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kentcdodds @ryanflorence @brophdawg11 @machour @sergiodxa @MichaelDeBoey