feat(manager/helm-values): Add support for bumpVersion#26441
Merged
viceice merged 16 commits intoJan 17, 2024
Conversation
kvanzuijlen
force-pushed
the
helm-values-bumpversion-support
branch
from
4692efe to
869fd72
Compare
Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
kvanzuijlen
force-pushed
the
helm-values-bumpversion-support
branch
from
869fd72 to
2a01fce
Compare
Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
kvanzuijlen
force-pushed
the
helm-values-bumpversion-support
branch
from
d8104e7 to
58ab838
Compare
kvanzuijlen
commented
Dec 27, 2023
Contributor
Author
kvanzuijlen
left a comment
kvanzuijlen
left a comment
There was a problem hiding this comment.
@rarkins I could reuse most parts from #8240. I was able to reproduce the behavior that caused it to be reverted.
Do you want to include helm-requirements in the same PR or should that (optionally) be added in a separate PR? I don't think it's really necessary, as helmv3 has long been the standard already and as far as I understand, helm-requirements is for Chart dependencies in helmv2 (correct?).
Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
kvanzuijlen
changed the title
viceice
reviewed
Dec 28, 2023
Contributor
|
Different managers can be done separately |
Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
Contributor
Author
|
Thanks for taking the time to review my PR @viceice. I hope my changes are correct. Let me know if I need to change anything else! |
viceice
reviewed
Dec 28, 2023
Signed-off-by: kvanzuijlen <8818390+kvanzuijlen@users.noreply.github.com>
4 tasks
viceice
reviewed
Jan 3, 2024
viceice
reviewed
Jan 3, 2024
… into helm-values-bumpversion-support
Contributor
Author
|
Thanks for all your patience @viceice. I made the requested changes. |
viceice
reviewed
Jan 3, 2024
6 tasks
viceice
approved these changes
Jan 17, 2024
|
🎉 This PR is included in version 37.138.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for
bumpVersionto the helm-values manager.Context
Closes #4728, closes #8231
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: