Skip to content

Add ability to customize helm values for deployment strategy #7900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmlamarche wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −0
Open

Add ability to customize helm values for deployment strategy #7900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c649b14
add helm values for deployment rollout strategy
Jan 17, 2026
38f3284
Merge pull request #1 from rmlamarche/feat-rollout-strategy
rmlamarche Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dev/helm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ The following table lists the configurable parameters of the Wiki.js chart and t
| `imagePullPolicy` | Image pull policy | `IfNotPresent` |
| `replicacount` | Number of Wiki.js pods to run | `1` |
| `revisionHistoryLimit` | Total number of revision history points | `10` |
| `strategy.type` | Strategy used to replace old pods by new ones | `RollingUpdate` |
| `strategy.rollingUpdate.maxSurge` | Maximum number of pods that can be created over the desired replica count during the upgrade process | `25%` |
| `strategy.rollingUpdate.maxUnavailable` | Maximum number of pods that can be unavailable during the upgrade process | `25%` |
| `resources.limits` | Wiki.js service resource limits | `nil` |
| `resources.requests` | Wiki.js service resource requests | `nil` |
| `nodeSelector` | Node labels for the Wiki.js pod assignment | `{}` |
Expand Down
7 changes: 7 additions & 0 deletions dev/helm/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ metadata:
spec:
replicas: {{ .Values.replicaCount }}
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
strategy:
type: {{ .Values.strategy.type }}
{{- if eq .Values.strategy.type "RollingUpdate" }}
rollingUpdate:
maxSurge: {{ .Values.strategy.rollingUpdate.maxSurge }}
maxUnavailable: {{ .Values.strategy.rollingUpdate.maxUnavailable }}
{{- end }}
selector:
matchLabels:
{{- include "wiki.selectorLabels" . | nindent 6 }}
Expand Down
6 changes: 6 additions & 0 deletions dev/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
replicaCount: 1
revisionHistoryLimit: 10

strategy:
type: "RollingUpdate"
rollingUpdate:
maxSurge: "25%"
maxUnavailable: "25%"

image:
repository: requarks/wiki
imagePullPolicy: IfNotPresent
Expand Down