@as support for @obj makes inconsistent conversion

[mununki]

Thanks to the PR #6412, we can rename the returned js object key name. But I found little inconsistent with the exisiting @as usage on record.

type t0 = {@as("a") type_: string}

@obj
external make: (@as("b") ~type_: string=?) => t0 = ""

let t0 = { type_: "t0"}

let t1 = make(~type_="t1")

let make = make

generated to

var t0 = {
  a: "t0"
};

var t1 = {
  b: "t1" // shouldn't be a?
};

function make(prim) {
  var tmp = {};
  if (prim !== undefined) {
    tmp.b = prim; // shouldn't be tmp.a = prim?
  }
  return tmp;
}

IMO, @as("b") would make rename the argument to b, but not affecting the returned value that needs to be kept a by @as("a")

What do you think? @DZakh

[DZakh]

I think it was always an unsafe conversion. So, the conversion right now looks correct to me.

[DZakh]

I'd even vote for deprecating @obj in v12 or something :)

[mununki]

Oh, I meant not unsafe, but inconsistent.

[mununki]

How about seperated it to two cased whether the return type field has @as deriver? If it doesn't have @as in the field of return type then it is renamed by the @as("b") from argument of external function. If it has @as in the field of the returned type then it is renamed to @as("a").

[DZakh]

zth/rescript-relay#467 (comment), also it won't work with opaque types

[mununki]

zth/rescript-relay#467 (comment), also it won't work with opaque types

I think this is an issue to resolve in rescript-relay, not compiler.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.