Remove dependencies to make more light weight#134
Open
BBC-Esq wants to merge 47 commits intoresemble-ai:masterfrom
Open
Remove dependencies to make more light weight#134BBC-Esq wants to merge 47 commits intoresemble-ai:masterfrom
BBC-Esq wants to merge 47 commits intoresemble-ai:masterfrom
Conversation
Remove librosa
Remove omegaconf
Remove conformer
|
This is very good idea to reduce dependencies, especially because torchaudio has almost same methods. Unfortunately, running tts conversion with default reference makes errors: Not sure what to do with this error: I tried to change Edit: After some refactoring figured out some version difference, but anyway has different error when replacing librosa to torchaudio |
Author
|
@Datel777 I will check that out and let you know. |
Updated project version, Python requirements, and dependencies.
Added comments for clarity and updated code for better readability.
Refactor audio loading and processing to use torchaudio instead of librosa. Update punctuation normalization and condition preparation methods.
Updated README to include new soundfile library and installation instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
perth,librosa,omegaconf, andconformeras dependencies.If I did it correctly it supersedes these PRs:
#128
#129
#130
#133
I had a fifth PR that removed
diffusersbut it was too difficult to implement. A lot of people like myself try to minimize the amount of dependencies so hopefully this helps.Dependencies like
librosaand others have a lot of dependencies in turn...for example, I think thatresampyis no longer required either. So overall this PR probably removes at least 10+ total dependencies. I tested and it works fine still.