Fix double invocation of schedule hooks for delayed jobs#812
Open
top-sigrid wants to merge 5 commits intoresque:masterfrom
Open
Fix double invocation of schedule hooks for delayed jobs#812top-sigrid wants to merge 5 commits intoresque:masterfrom
top-sigrid wants to merge 5 commits intoresque:masterfrom
Conversation
Author
|
Regarding my discussion points from #810 I went with the solution that for enqueing recurring cron jobs the schedule-hooks are also called. Altgough that doesn't mean they are "placed on the delayed queue" I think this actually is a scheduling operation. Also #792 just a year ago quite explicitely introduced this. Hence I adjusted the Readme on this new functioning of the hooks. I hope you are fine with this approach, cc @PatrickTulskie. I think the CI failures are all unrelated to this fix. There is 1 actual test failure for Ruby 2.4 that I'll look into. Let me know what you think of this and happy holidays Edit: I also opened #813 for the flaky test (as it is unrelated to the changes in this PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #810
Summary
enqueue_from_configtoenqueue_recurringextract_klass_and_paramshelper to avoid duplication