Auto-enable vqueues on leader transition when config flag is set#4777
Merged
tillrohrmann merged 2 commits intoMay 21, 2026
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
AhmedSoliman
approved these changes
May 21, 2026
Extend the StateMachineFeatures trait with is_vqueues_enabled (gated on the persisted feature flag) and move the impl from SemanticRestateVersion to StateMachine + StateMachineApplyContext so each method can consult both the min Restate version and the persisted feature set. Replace the in-state-machine Configuration::pinned().common.experimental.is_vqueues_enabled() call sites with self.is_vqueues_enabled() / ctx.is_vqueues_enabled(). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
When a partition becomes leader and Configuration::common::experimental has is_vqueues_enabled() set, propose a VersionBarrierCommand carrying PartitionFeatureChange::EnableVqueues — but only if the FSM hasn't already recorded the opt-in. The persisted state update flows through the existing OnVersionBarrierCommand apply path; become_leader does not touch the FSM mirror locally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tillrohrmann
force-pushed
the
enable-vqueues-version-barrier
branch
from
8573509 to
1ff7d8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a partition becomes leader and Configuration::common::experimental
has is_vqueues_enabled() set, propose a VersionBarrierCommand carrying
PartitionFeatureChange::EnableVqueues — but only if the FSM hasn't already
recorded the opt-in. The persisted state update flows through the existing
OnVersionBarrierCommand apply path; become_leader does not touch the FSM
mirror locally.