Skip to content

Fix a regression in reverse_lookup_filter introduced in #699 #701

Merged
eagleoflqj merged 2 commits into
rime:masterfrom
ksqsf:master
Sep 3, 2023
Merged

Fix a regression in reverse_lookup_filter introduced in #699 #701
eagleoflqj merged 2 commits into
rime:masterfrom
ksqsf:master

Conversation

@ksqsf

@ksqsf ksqsf commented Sep 3, 2023

Copy link
Copy Markdown
Member

Pull request

Issue tracker

Reported by @eagleoflqj ; Fix a regression introduced by #699

#699 mistakenly assumed at least one of append_comment and overwrite_comment is true, and will break the old behavior. This PR fixes this.

Sorry for my mistake :(

Feature

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@ksqsf ksqsf marked this pull request as ready for review September 3, 2023 05:55
@eagleoflqj

Copy link
Copy Markdown
Member

Changed the logic a bit.

seq overwrite append empty e825f7d fd1a6dc
0 0 0 0 return early return early
1 0 0 1 overwrite overwrite
2 0 1 0 append append
3 0 1 1 append overwrite
4-7 1 ? ? overwrite overwrite

The only difference with your commit is when !overwrite && append && empty, I think in this case better not adding a extraneous space.

@eagleoflqj eagleoflqj merged commit 8af548f into rime:master Sep 3, 2023
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
…e#701)

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants