Conversation
SParente
left a comment
There was a problem hiding this comment.
looks really good, and important. i would clean the any, just to be more "pretty" and more prepared for the future. added a sugestion to improve that.
| return { | ||
| top: result.top + marginTop, | ||
| bottom: result.bottom + marginBottom, | ||
| left: result.left + marginLeft, | ||
| right: result.right + marginRight, | ||
| width: result.width + marginLeft + marginRight, | ||
| height: result.height + marginTop + marginBottom |
There was a problem hiding this comment.
i would avoid to use anys. i like to respect the type, just to prevent possible errors on the future. for example, if we need the x and y, and we dont use, we can pass as zero. the the toJSON can be done with a simple json stringify. see an exemple in the sugestion
| return { | |
| top: result.top + marginTop, | |
| bottom: result.bottom + marginBottom, | |
| left: result.left + marginLeft, | |
| right: result.right + marginRight, | |
| width: result.width + marginLeft + marginRight, | |
| height: result.height + marginTop + marginBottom | |
| const result = { | |
| x: 0, | |
| y: 0, | |
| top: result.top + marginTop, | |
| bottom: result.bottom + marginBottom, | |
| left: result.left + marginLeft, | |
| right: result.right + marginRight, | |
| width: result.width + marginLeft + marginRight, | |
| height: result.height + marginTop + marginBottom, | |
| }; | |
| return { | |
| ...base, | |
| toJSON: () => { | |
| return JSON.stringify(base); | |
| } | |
| } |
There was a problem hiding this comment.
Since this is blocking everyone updating to angular 13 while keeping the scroller, would it be possible to go ahead with the current implementation and creating an issue out of this?
There was a problem hiding this comment.
Hi @rintoj is it possible to merge this branch and release a new version?
|
Last year I asked for a new release, because the last one was the year before. Nothing changed so it's been 2 years now. Is there any point for people to keep investing their time developing in this project? Unless someone forks this and starts releasing then we should all move on to another component. |
|
@iharbeck published an angular 13 version on npm: Do we consider this one? |
|
any news on this? |
|
Sorry everyone I forgot about this branch. Unfortunately I do not have permissions to merge this but I may release it under our own orgs scope and update it to angular 14, I just do not know if we want to maintain the library or not. |
No description provided.