Add configuration option to handle reserved dynamic rounding modes.#1491
Merged
Timmmm merged 3 commits intoriscv:masterfrom Jan 31, 2026
Merged
Add configuration option to handle reserved dynamic rounding modes.#1491Timmmm merged 3 commits intoriscv:masterfrom
Timmmm merged 3 commits intoriscv:masterfrom
Conversation
jordancarlin
requested changes
Jan 17, 2026
16 tasks
pmundkur
added
the
configuration
challenger1024
force-pushed
the
floating-point-rounding-mode
branch
from
c57fb83 to
e14bc29
Compare
challenger1024
force-pushed
the
floating-point-rounding-mode
branch
from
e14bc29 to
b125361
Compare
Contributor
Author
|
Final commit: rebase and moved the match logic to the appropriate location. |
Timmmm
requested changes
Jan 29, 2026
Collaborator
Timmmm
left a comment
Timmmm
left a comment
There was a problem hiding this comment.
LGTM with some minor tweaks.
Collaborator
|
Also I agree we should have a separate option for the reserved static rounding modes. |
challenger1024
force-pushed
the
floating-point-rounding-mode
branch
from
74aceda to
b3dc14f
Compare
pmundkur
approved these changes
Jan 30, 2026
Collaborator
pmundkur
left a comment
pmundkur
left a comment
There was a problem hiding this comment.
LGTM with a minor nit.
pmundkur
changed the title
Collaborator
|
We should adjust the PR text when merging. |
challenger1024
force-pushed
the
floating-point-rounding-mode
branch
from
b3dc14f to
190a9ba
Compare
jordancarlin
approved these changes
Jan 31, 2026
Timmmm
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a configuration option for cases where float instructions use a dynamic rounding mode (i.e. use the value from
fcsr[FRM]) andfcsr[FRM]contains a reserved value (0b101, 0b110, or 0b111).This does not affect reserved static rounding modes (0b101 or 0b110 encoded in the instruction) which might need different options.