cornered box annotator#171
Merged
SkalskiP merged 19 commits intoroboflow:feature/redesigned_annotatorsfrom Jul 23, 2023
hardikdava:advanced_box_annotator
Merged
cornered box annotator#171SkalskiP merged 19 commits intoroboflow:feature/redesigned_annotatorsfrom hardikdava:advanced_box_annotator
SkalskiP merged 19 commits intoroboflow:feature/redesigned_annotatorsfrom
hardikdava:advanced_box_annotator
Conversation
Merged
Redesigned annotators
Contributor
Author
|
@SkalskiP Please merge this branch before further work. I already finished some implementation. |
Contributor
Author
Contributor
Author
Contributor
Author
|
@SkalskiP I changed code style to consistent style as |
Contributor
Author
SkalskiP
approved these changes
Jul 13, 2023
SkalskiP
requested changes
Jul 18, 2023
Collaborator
|
@hardikdava I left you few comments already. I'm taking a look at the rest of the code, as well as testing it. But there are a few things that I need to think about tomorrow. Please start implementing the changes I already listed. 🙏🏻 |
SkalskiP
requested changes
Jul 20, 2023
Contributor
Author
|
@SkalskiP I have added tests for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #168 and #170 . Merging new annotation format for initial commit.
@SkalskiP it might needed to refine a bit.
Type of change