Skip to content

cornered box annotator#171

Merged
SkalskiP merged 19 commits intoroboflow:feature/redesigned_annotatorsfrom
hardikdava:advanced_box_annotator
Jul 23, 2023
Merged

cornered box annotator#171
SkalskiP merged 19 commits intoroboflow:feature/redesigned_annotatorsfrom
hardikdava:advanced_box_annotator

Conversation

@hardikdava
Copy link
Copy Markdown
Contributor

Description

As discussed in #168 and #170 . Merging new annotation format for initial commit.

@SkalskiP it might needed to refine a bit.

Type of change

  • New feature (non-breaking change which adds functionality)

@hardikdava hardikdava mentioned this pull request Jul 3, 2023
@hardikdava
Copy link
Copy Markdown
Contributor Author

@SkalskiP Please merge this branch before further work. I already finished some implementation.

@hardikdava
Copy link
Copy Markdown
Contributor Author

@SkalskiP #49 is also included in this PR.

@SkalskiP SkalskiP added the version: 0.12.0 Feature to be added in `0.12.0` release label Jul 4, 2023
@hardikdava
Copy link
Copy Markdown
Contributor Author

@SkalskiP This feature is ready for review. It includes #49 #159 #168 features.

@hardikdava
Copy link
Copy Markdown
Contributor Author

@SkalskiP I changed code style to consistent style as Annotators.annotate(scene, detection) format. Please review it and merge the PR.

@hardikdava
Copy link
Copy Markdown
Contributor Author

hardikdava commented Jul 7, 2023

@SkalskiP EllipseAnotator is also added to the Annotators API. #16

@hardikdava hardikdava mentioned this pull request Jul 17, 2023
1 task
@SkalskiP SkalskiP added this to the version: 0.12.0 milestone Jul 18, 2023
Comment thread supervision/detection/track.py Outdated
Comment thread supervision/detection/track.py Outdated
@SkalskiP
Copy link
Copy Markdown
Collaborator

@hardikdava I left you few comments already. I'm taking a look at the rest of the code, as well as testing it. But there are a few things that I need to think about tomorrow. Please start implementing the changes I already listed. 🙏🏻

Comment thread supervision/detection/track.py Outdated
Comment thread supervision/annotators/core.py Outdated
Comment thread supervision/annotators/core.py
@hardikdava
Copy link
Copy Markdown
Contributor Author

@SkalskiP I have added tests for get_anchor_coordinates

@SkalskiP SkalskiP merged commit 1d28b8a into roboflow:feature/redesigned_annotators Jul 23, 2023
@hardikdava hardikdava deleted the advanced_box_annotator branch August 10, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version: 0.12.0 Feature to be added in `0.12.0` release

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants