Skip to content

Decouple mask and bndbox Detections (for VOC)#263

Draft
kirilllzaitsev wants to merge 6 commits intoroboflow:developfrom
kirilllzaitsev:feature/segm_ds
Draft

Decouple mask and bndbox Detections (for VOC)#263
kirilllzaitsev wants to merge 6 commits intoroboflow:developfrom
kirilllzaitsev:feature/segm_ds

Conversation

@kirilllzaitsev
Copy link
Copy Markdown
Contributor

@kirilllzaitsev kirilllzaitsev commented Aug 2, 2023

Description

Addresses this issue. In the context of the VOC format, Detections are allowed to have either xyxy or mask field non-empty. Previous behavior to handle both xyxy and mask is supported, but a deprecation warning is issued.

The way to dump a dataset to disk is changed to a separate XMLBuilder class.

List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • [+] This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Tested with either of (xyxy, mask), (xyxy), (mask) available.

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@kirilllzaitsev
Copy link
Copy Markdown
Contributor Author

kirilllzaitsev commented Aug 2, 2023

@SkalskiP here is a starter patch of changes on the transition path to decoupled object detection and segmentation. Taking VOC format as a playground:

  • logic for dumping a a Detections object is encapsulated in XMLBuilder
  • having both xyxy and mask issues a deprecation message (pulled up to the dataset level (from_pascal_voc) if we agree that deprecating now is the right thing)

If the direction with xyxy and mask looks good, I will create a SegmentationDataset, further simplifying detections_to_pascal_voc. Otherwise, if the segmentation-related matters are too much for now, at least XMLBuilder looks like an enhancement.

@SkalskiP SkalskiP added enhancement New feature or request API:datasets Dataset API version 0.14.0 Feature to be added in `0.14.0` release labels Aug 7, 2023
@SkalskiP SkalskiP added this to the version: 0.14.0 milestone Aug 7, 2023
@SkalskiP
Copy link
Copy Markdown
Collaborator

SkalskiP commented Aug 7, 2023

Hi, @kirilllzaitsev! 👋🏻 I marked this PR as a 0.14.0 release. I'm super busy with wrapping work on a few 0.13.0 features as we plan to release tomorrow. Please be patient 🙏🏻

@hardikdava and @artyaltanzaya could you take a look at the PR in the meantime?

@SkalskiP SkalskiP requested a review from artyaltanzaya August 7, 2023 10:17
@SkalskiP
Copy link
Copy Markdown
Collaborator

SkalskiP commented Aug 7, 2023

@capjamesg @yeldarby I think you should know we are working on those changes. They might influence Autodistill.

@kirilllzaitsev kirilllzaitsev marked this pull request as draft August 7, 2023 21:05
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 11, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API:datasets Dataset API enhancement New feature or request has conflicts version 0.14.0 Feature to be added in `0.14.0` release

Projects

Status: Current Release: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants