Changed the Node resolving to be more reliable, fixing some issues#173
Merged
Changed the Node resolving to be more reliable, fixing some issues#173
Conversation
Sometimes _resolveFilename will be called without parent.id being present which would result in a crash with the previous logic. This change addresses this and instead uses parent.paths[0] for the same functionality. This solves in particular some problems that have been seen when used together with babel-plugin-lodash.
PAkerstrand
approved these changes
May 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes _resolveFilename will be called without
parent.idbeing present which would result in a crash with the previous logic. This change addresses this and instead usesparent.paths[0]for the same functionality.This solves in particular some problems that have been seen when used together with
babel-plugin-lodash.