Repository navigation
Conversation
Requested in the rohitg00#1182 review: the project keeps comments out of code, and the reasoning already lives in that PR's description. Signed-off-by: Dmitrii Zhukov <dmitry0983@gmail.com>
|
@dmazhukov is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughTests cover whether legacy snapshot migration writes ChangesAudit index persistence
Priority: ⚪ Not assessed Estimated code review effort: 2 (Simple) | ~8 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change adds focused regression coverage for migration audit gating without changing production behavior. No material merge risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # test/index-persistence.test.ts
Main's index persistence rewrite removed the rohitg00#1182 comments along with the audit gating tests. Restore the tests without comments against the bucketed storage API: index_persist entries are written on legacy migration only when AGENTMEMORY_AUDIT_INDEX_PERSIST is 1 or true.
|
Thanks @dmazhukov. The comments from #1182 were already removed on main when the index storage was rewritten, so this PR no longer has anything left to change. Closing. |
Follow-up to #1182: removes the comment block above
auditIndexPersistEnabled()as requested in review, plus the comments I added to its tests. No behaviour change.Summary by CodeRabbit