Skip to content

chore(audit): drop the code comments added in #1182 - #1412

Closed
dmazhukov wants to merge 3 commits into
rohitg00:mainfrom
dmazhukov:fix/1181-drop-audit-gate-comment
Closed

dmazhukov wants to merge 3 commits into
rohitg00:mainfrom
dmazhukov:fix/1181-drop-audit-gate-comment

Conversation

@dmazhukov

@dmazhukov dmazhukov commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Follow-up to #1182: removes the comment block above auditIndexPersistEnabled() as requested in review, plus the comments I added to its tests. No behaviour change.

Summary by CodeRabbit

  • Tests
    • Added coverage for audit logging behavior during legacy snapshot migration, including default settings and supported flag values.
    • Verified that unsupported or blank flag values do not produce audit entries.

Requested in the rohitg00#1182 review: the project keeps comments out of code, and the reasoning already lives in that PR's description.

Signed-off-by: Dmitrii Zhukov <dmitry0983@gmail.com>
@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

@dmazhukov is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (1)
AGENTS.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 8c608b0e-ea44-4f57-981c-7bb0a8213dc8

📥 Commits

Reviewing files that changed from the base of the PR and between 2951d59 and 3affe3d.

📒 Files selected for processing (1)
  • test/index-persistence.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

Tests cover whether legacy snapshot migration writes index_persist audit entries for different values of AGENTMEMORY_AUDIT_INDEX_PERSIST.

Changes

Audit index persistence

Layer / File(s) Summary
Test migration audit gating
test/index-persistence.test.ts
Adds migration test setup and an audit-entry collector. Tests verify that auditing is disabled by default and for "0", "false", "yes", and blank values, and enabled for "1" and case- or whitespace variants of "true".

Priority: ⚪ Not assessed

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: rohitg00

Merge Risk: ⚪ Minimal · up to 3affe

This change adds focused regression coverage for migration audit gating without changing production behavior. No material merge risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: removing code comments added in issue #1182. It matches the stated pull request objective and is concise.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

# Conflicts:
#	test/index-persistence.test.ts
Main's index persistence rewrite removed the rohitg00#1182 comments along with
the audit gating tests. Restore the tests without comments against the
bucketed storage API: index_persist entries are written on legacy
migration only when AGENTMEMORY_AUDIT_INDEX_PERSIST is 1 or true.
@rohitg00

rohitg00 commented Oct 1, 2026

Copy link
Copy Markdown
Owner

Thanks @dmazhukov. The comments from #1182 were already removed on main when the index storage was rewritten, so this PR no longer has anything left to change. Closing.

@rohitg00 rohitg00 closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants