Repository navigation
fix(cli): say when an agent is connected with MCP only - #1756
Conversation
An agent connected with MCP only and no hooks captures nothing on its own. Observations are stored only when the agent calls memory_save. connect and status never said so, so users expected automatic capture. connect now prints one line after an MCP-only setup. It names --with-hooks only for adapters that can install hooks, points plugin-based agents at their plugin, and otherwise says the agent must call memory_save. Each adapter declares its capture mode in a new autoCapture field; JSON MCP adapters with a hook installer get "with-hooks" automatically. The status report and the status command warn when the server has no sessions and no capture activity, which means no hook has reached it yet. Sessions come from hooks or imports, never from MCP calls, so the existing session count is the signal. No new storage is added. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
Run npm run docs:sync after the MCP-only capture notice change. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough
Merge Risk:
|
Adapters now report whether their hooks were installed. The connect notice stays quiet only when hooks are confirmed, and it warns when --with-hooks was passed but the hook install was skipped. DSH reports hook rows it keeps in place. connect codex --with-hooks on an already-wired config now installs the hooks before it returns. The no-hook warning in status needs a known capture state. A capture check that timed out no longer triggers it, and the CLI reads the capture endpoint so accepted, queued or spooled captures suppress it. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
|
Review-body findings:
|
A DSH hook row whose plugin file is gone no longer counts as installed. The plugin-or-with-hooks notice keeps the plugin option when hooks fail. The status check skips the diagnosis when the capture inbox is unreadable and says capture was not observed yet instead of claiming it is off. The CLI counts sessions across all agents and types the capture response. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
An unreadable capture inbox now reports capture-check-unavailable. The spool summary flags read errors other than a missing file, and the no-hook diagnosis is skipped while the spool cannot be read. A legacy DSH bridge row counts as installed only while its manifest exists. The no-hook message separates memories from observations and only offers hooks or a plugin for agents that support them. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
An unreadable spool now adds capture-check-unavailable, so status cannot report that every check passed. The spool summary reads the primary file directly, so an access error is not taken for an empty spool. A legacy DSH bridge row no longer counts as installed hooks; the notice points those users at the bundled plugin through --with-hooks. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
When a spool cannot be read, the capture-check-unavailable fix now names each spool path and asks the user to check that agentmemory can read it. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
|
@codex review |
Resolve the src/cli.ts import conflict by keeping the worker-connection import from this branch and the hook-capture status imports from #1756. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
spoolSummary keeps this branch's unreadable count and takes the check from #1756: a read error other than ENOENT on the spool file, a claim or the spool folder counts as unreadable. The main-branch test now expects counts instead of a boolean. Documented counts are re-synced. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
Agents connected with MCP only capture nothing automatically. Observations are stored only when the agent calls memory_save, and several users asked why nothing was saved.
connectprints one line after an MCP-only setup. It suggests --with-hooks only for adapters that can install hooks, points plugin-based agents at their plugin, and otherwise says the agent must call memory_save.autoCapturefield.no-hook-capture) when the server has no sessions and no capture activity. It uses the existing session count; no new storage.Behavior change: a fresh install reports warn instead of ok until the first hook arrives. The second commit is only
docs:syncoutput and can be dropped if it conflicts.Found through docs-assistant questions from users.
Test notes: targeted tests pass. Full-suite failures seen locally (fs-watcher, observation-source, graph timeouts) also fail on a clean origin/main checkout under load.
Summary by CodeRabbit