Repository navigation
fix(release-gate): force the dead-letter capture failure without the session cap - #1766
Conversation
…session cap The deadletter scenario made the third capture fail by starting with MAX_OBS_PER_SESSION=2. Since #1174 the cap evicts the lowest-value observation instead of refusing the write, so the capture succeeded, no dead letter appeared and the scenario timed out on every platform. mem::observe now rejects a capture whose data contains the value of AGENTMEMORY_RELEASE_GATE_FAIL_OBSERVE. The variable is unset in normal use, so nothing changes for users. The gate sets it to the third marker, restarts without it, and the retry recovers the capture as before. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The switch is for the release gate only, so it now ends in two underscores like AGENTMEMORY_MCP_STDIO__. The skill reference generator skips such internal markers, so the variable does not appear as a user setting and skills:check passes. Documented counts are re-synced. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
Problem
The release gate fails the
deadletterscenario on every platform since #1174 merged:The scenario forced a capture failure by starting with
MAX_OBS_PER_SESSION=2. Since #1174, the session cap evicts the lowest-value observation instead of refusing the write. The third capture now succeeds, so no dead letter appears. Every open PR fails the packed-artifact jobs for this reason.Fix
mem::observerejects a capture whose data contains the value ofAGENTMEMORY_RELEASE_GATE_FAIL_OBSERVE__. The variable is unset in normal use, so behavior does not change for users.deadletterscenario sets it to the third marker, then restarts without it. The retry recovers the capture as before.Testing
npm run release:gate -- --only deadletterpasses locally against the packed artifact and the real engine. The dead letter recordsrelease gate: AGENTMEMORY_RELEASE_GATE_FAIL_OBSERVE__ rejected this capture.test/auto-compress.test.ts: only captures with the marker are rejected.Summary by CodeRabbit