Skip to content

fix(funding): tighten FUNDING.yml to canonical single-line form - #547

Merged
rohitg00 merged 1 commit into
mainfrom
fix/funding-yml-tighten
May 19, 2026
Merged

rohitg00 merged 1 commit into
mainfrom
fix/funding-yml-tighten

Conversation

@rohitg00

@rohitg00 rohitg00 commented May 19, 2026 •

Copy link
Copy Markdown
Owner

Sponsor button missing on the repo page after #545 merged. Diff strips the 4-line comment prefix so the file matches GitHub's documented FUNDING schema exactly.

github: [rohitg00]

Sponsor profile is enabled (github.com/sponsors/rohitg00 returns 200 + 'Sponsor @rohitg00' button). The blocker is GitHub's side-bar indexer not picking up the file from #545 yet. Tightening forces a re-parse.

Companion fix (separate)

The Packages sidebar widget is also empty because no release has been published since the publish-github-packages job was added. To populate it without cutting v0.9.21:

gh workflow run publish.yml --repo rohitg00/agentmemory

The existing if npm view ... skipping guards make this safe — public-npm jobs short-circuit, only the new GH Packages job actually does work. After it completes, @rohitg00/agentmemory should appear in the right-sidebar Packages section.

Need maintainer approval to dispatch — happy to run it once you greenlight, or you can fire it from the Actions tab directly.

Summary by CodeRabbit

  • Chores
    • Simplified GitHub Sponsors funding configuration by removing unnecessary comments.

Review Change Stack

… FUNDING.yml

Sponsor button still missing from the repo page despite #545 merging.
The committed FUNDING.yml started with 4 lines of `#` comments before
the canonical `github: [rohitg00]` directive. GitHub's FUNDING parser
documents only the canonical key-value form; leading comments
shouldn't break it but some users have reported indexer lag when the
file starts with non-data lines. Strip to the bare single-line form
to match the documented schema and remove any ambiguity.

Sponsor profile is enabled (github.com/sponsors/rohitg00 returns 200
+ 'Sponsor @rohitg00' button), so the only remaining gap is GitHub's
side-bar indexing. Tightening the file forces a re-parse.
@vercel

vercel Bot commented May 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agentmemory Ready Ready Preview, Comment May 19, 2026 5:44pm

Request Review

@coderabbitai

coderabbitai Bot commented May 19, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5002efab-42cd-427d-b9b7-dad1c8724d0c

📥 Commits

Reviewing files that changed from the base of the PR and between b425922 and 1e0aecf.

📒 Files selected for processing (1)
  • .github/FUNDING.yml

📝 Walkthrough

Walkthrough

This PR removes explanatory comments from .github/FUNDING.yml while preserving the active GitHub Sponsors configuration. The github: [rohitg00] funding handle remains unchanged.

Changes

Funding Configuration

Layer / File(s) Summary
Funding configuration comment cleanup
.github/FUNDING.yml
Removes the multi-line guidance comment explaining the Sponsor button behavior while retaining the github: [rohitg00] funding handle.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Possibly related PRs

Poem

🐰 A comment departs, yet sponsors remain,
The config stays clean, without the refrain.
One line of funding, simple and bright,
GitHub's path to support, simplified right.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/funding-yml-tighten

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohitg00
rohitg00 merged commit 6ed47c1 into main May 19, 2026
4 of 5 checks passed
@rohitg00
rohitg00 deleted the fix/funding-yml-tighten branch May 19, 2026 17:45
healdigital pushed a commit to healdigital/agentmemory that referenced this pull request Jul 27, 2026
…tg00#547)

Sponsor button still missing from the repo page despite rohitg00#545 merging.
The committed FUNDING.yml started with 4 lines of `#` comments before
the canonical `github: [rohitg00]` directive. GitHub's FUNDING parser
documents only the canonical key-value form; leading comments
shouldn't break it but some users have reported indexer lag when the
file starts with non-data lines. Strip to the bare single-line form
to match the documented schema and remove any ambiguity.

Sponsor profile is enabled (github.com/sponsors/rohitg00 returns 200
+ 'Sponsor @rohitg00' button), so the only remaining gap is GitHub's
side-bar indexing. Tightening the file forces a re-parse.

This branch was successfully deployed

1 active deployment
Preview — 1e0aecfe Deployed May 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant