Repository navigation
fix(deps): pin iii-sdk to 0.11.2 (closes #555) - #567
Conversation
iii-sdk@0.11.6 changes nested behavior so that all /agentmemory/* routes return 404 against the iii-engine, even though both packages still satisfy the previous "^0.11.2" semver range. npm picked up the new version on `npm install -g @agentmemory/agentmemory` after 0.9.21 shipped, silently breaking installs. Two pin sites: 1. package.json — caret -> exact "0.11.2" so npm cannot drift forward on minor releases until the upstream regression is sorted. 2. src/cli.ts — `agentmemory setup` previously ran `pnpm up iii-sdk@latest` / `npm install iii-sdk@latest`, which would re-pull 0.11.6+ even after a freshly-pinned install. Both call sites now pin to 0.11.2 with a label referencing this issue. Tests (1081) + build pass against iii-sdk@0.11.2. Closes #555.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughPackage dependency and CLI upgrade/install commands are updated to pin ChangesPin iii-sdk to 0.11.2
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Source labels should describe what the code does, not point at issues that rot as the codebase evolves. Issue context lives in the PR body.
…uard (#588) Three concerns surfaced when auditing PRs merged since v0.9.21: 1) Graph parser regex from #494 was correct for self-closing tags ONLY when they're the only entity in the document. With a self-closing entity followed by an explicit-close entity, the greedy `[^>]*` ate the trailing `/` of the self-close, the alternation fell through to the explicit-close branch, and `[\s\S]*?` ran ahead to the *next* `</entity>` — merging two entity declarations into one match and silently dropping a node. Switch to lazy `[^>]*?` so the self-closing alternation gets first chance. Test from #494 (which was failing on main but I didn't notice) now passes. 2) #386 shipped `${AGENTMEMORY_URL}` / `${AGENTMEMORY_SECRET}` placeholders in plugin/.mcp.json. Claude Code and Cursor expand those at MCP launch time; some hosts pass the literal string through. A truthy literal `"${AGENTMEMORY_URL}"` defeats the existing `|| DEFAULT_URL` fallback and would have the shim POST to `${AGENTMEMORY_URL}/agentmemory/...` (DNS failure). Add a defensive guard in src/mcp/rest-proxy.ts that strips any value of the form `${...}` so the fallback engages. Mirror in src/mcp/standalone.ts's mode-announce log line. 3) CHANGELOG entries for all PRs landed since v0.9.21 (#321, #325, #386, #454, #494, #526, #542, #560, #561, #562, #564, #567) plus the regex + env-guard hardening here. Validation: - npm test → 98 files, 1091 tests pass - npm pack → 142 files, fresh install clean, iii-sdk@0.11.2 pinned, plugin/ shipped with hooks/scripts/skills/opencode/ - New test file covers 8 placeholder cases (unset, empty, `${VAR}` literal, mismatched braces, real values with $, unclosed `${`, no-braces `$VAR`).
* fix(deps): pin iii-sdk to 0.11.2 to avoid routing regression in 0.11.6 iii-sdk@0.11.6 changes nested behavior so that all /agentmemory/* routes return 404 against the iii-engine, even though both packages still satisfy the previous "^0.11.2" semver range. npm picked up the new version on `npm install -g @agentmemory/agentmemory` after 0.9.21 shipped, silently breaking installs. Two pin sites: 1. package.json — caret -> exact "0.11.2" so npm cannot drift forward on minor releases until the upstream regression is sorted. 2. src/cli.ts — `agentmemory setup` previously ran `pnpm up iii-sdk@latest` / `npm install iii-sdk@latest`, which would re-pull 0.11.6+ even after a freshly-pinned install. Both call sites now pin to 0.11.2 with a label referencing this issue. Tests (1081) + build pass against iii-sdk@0.11.2. Closes rohitg00#555. * fix(cli): drop issue ref from iii-sdk pin label Source labels should describe what the code does, not point at issues that rot as the codebase evolves. Issue context lives in the PR body.
…uard (rohitg00#588) Three concerns surfaced when auditing PRs merged since v0.9.21: 1) Graph parser regex from rohitg00#494 was correct for self-closing tags ONLY when they're the only entity in the document. With a self-closing entity followed by an explicit-close entity, the greedy `[^>]*` ate the trailing `/` of the self-close, the alternation fell through to the explicit-close branch, and `[\s\S]*?` ran ahead to the *next* `</entity>` — merging two entity declarations into one match and silently dropping a node. Switch to lazy `[^>]*?` so the self-closing alternation gets first chance. Test from rohitg00#494 (which was failing on main but I didn't notice) now passes. 2) rohitg00#386 shipped `${AGENTMEMORY_URL}` / `${AGENTMEMORY_SECRET}` placeholders in plugin/.mcp.json. Claude Code and Cursor expand those at MCP launch time; some hosts pass the literal string through. A truthy literal `"${AGENTMEMORY_URL}"` defeats the existing `|| DEFAULT_URL` fallback and would have the shim POST to `${AGENTMEMORY_URL}/agentmemory/...` (DNS failure). Add a defensive guard in src/mcp/rest-proxy.ts that strips any value of the form `${...}` so the fallback engages. Mirror in src/mcp/standalone.ts's mode-announce log line. 3) CHANGELOG entries for all PRs landed since v0.9.21 (rohitg00#321, rohitg00#325, rohitg00#386, rohitg00#454, rohitg00#494, rohitg00#526, rohitg00#542, rohitg00#560, rohitg00#561, rohitg00#562, rohitg00#564, rohitg00#567) plus the regex + env-guard hardening here. Validation: - npm test → 98 files, 1091 tests pass - npm pack → 142 files, fresh install clean, iii-sdk@0.11.2 pinned, plugin/ shipped with hooks/scripts/skills/opencode/ - New test file covers 8 placeholder cases (unset, empty, `${VAR}` literal, mismatched braces, real values with $, unclosed `${`, no-braces `$VAR`).
Summary
Closes #555.
iii-sdk@0.11.6changed nested routing behavior so that every/agentmemory/*route returns404against the iii-engine, even though0.11.6still satisfies our previous"^0.11.2"range.npm install -g @agentmemory/agentmemorysilently drifted everyone forward after 0.9.21 shipped, breaking the REST server with no visible signal.Pin sites
package.json—"iii-sdk": "^0.11.2"→"iii-sdk": "0.11.2". Caret-range removed; npm can no longer pick up minor or patch releases until we explicitly re-pin.src/cli.ts— theagentmemory setupflow previously ranpnpm up iii-sdk@latest/npm install iii-sdk@latest. That would re-pull0.11.6+even after a freshly pinned install. Both call sites now pin to0.11.2with a label that references iii-sdk@0.11.6 breaks routing — nested dependency needs pin #555 so the intent is obvious in logs.Validation
npm install --legacy-peer-deps→iii-sdk@0.11.2resolvednpm test→ 97/97 test files, 1081/1081 tests passnpm run build→ bundles cleanForward path
When the upstream regression is sorted, bump to the fixed version explicitly (don't switch back to caret) so we never silently drift again.
Summary by CodeRabbit