Skip to content

fix(deps): pin iii-sdk to 0.11.2 (closes #555) - #567

Merged
rohitg00 merged 2 commits into
mainfrom
fix/pin-iii-sdk-0.11.2
May 20, 2026
Merged

rohitg00 merged 2 commits into
mainfrom
fix/pin-iii-sdk-0.11.2

Conversation

@rohitg00

@rohitg00 rohitg00 commented May 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes #555.

iii-sdk@0.11.6 changed nested routing behavior so that every /agentmemory/* route returns 404 against the iii-engine, even though 0.11.6 still satisfies our previous "^0.11.2" range. npm install -g @agentmemory/agentmemory silently drifted everyone forward after 0.9.21 shipped, breaking the REST server with no visible signal.

Pin sites

  1. package.json — "iii-sdk": "^0.11.2" → "iii-sdk": "0.11.2". Caret-range removed; npm can no longer pick up minor or patch releases until we explicitly re-pin.

  2. src/cli.ts — the agentmemory setup flow previously ran pnpm up iii-sdk@latest / npm install iii-sdk@latest. That would re-pull 0.11.6+ even after a freshly pinned install. Both call sites now pin to 0.11.2 with a label that references iii-sdk@0.11.6 breaks routing — nested dependency needs pin #555 so the intent is obvious in logs.

Validation

  • npm install --legacy-peer-deps → iii-sdk@0.11.2 resolved
  • npm test → 97/97 test files, 1081/1081 tests pass
  • npm run build → bundles clean

Forward path

When the upstream regression is sorted, bump to the fixed version explicitly (don't switch back to caret) so we never silently drift again.

Summary by CodeRabbit

  • Chores
    • Pinned the iii-sdk dependency to exact version 0.11.2 in project configuration (replacing a flexible version range).
    • The upgrade workflow now installs/pins iii-sdk@0.11.2 for both npm and pnpm paths instead of updating to the latest release, ensuring consistent dependency resolution.

Review Change Stack

iii-sdk@0.11.6 changes nested behavior so that all /agentmemory/* routes
return 404 against the iii-engine, even though both packages still
satisfy the previous "^0.11.2" semver range. npm picked up the new
version on `npm install -g @agentmemory/agentmemory` after 0.9.21
shipped, silently breaking installs.

Two pin sites:

1. package.json — caret -> exact "0.11.2" so npm cannot drift forward
   on minor releases until the upstream regression is sorted.

2. src/cli.ts — `agentmemory setup` previously ran
   `pnpm up iii-sdk@latest` / `npm install iii-sdk@latest`, which would
   re-pull 0.11.6+ even after a freshly-pinned install. Both call sites
   now pin to 0.11.2 with a label referencing this issue.

Tests (1081) + build pass against iii-sdk@0.11.2.

Closes #555.
@vercel

vercel Bot commented May 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agentmemory Ready Ready Preview, Comment May 20, 2026 3:21pm

Request Review

@coderabbitai

coderabbitai Bot commented May 20, 2026 •

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Package dependency and CLI upgrade/install commands are updated to pin iii-sdk to exact version 0.11.2 instead of a caret range or @latest.

Changes

Pin iii-sdk to 0.11.2

Layer / File(s) Summary
Dependency manifest pin
package.json
iii-sdk dependency changes from caret-ranged ^0.11.2 to exact version 0.11.2.
CLI upgrade command update
src/cli.ts
runUpgrade updated to use iii-sdk@0.11.2 for both pnpm (pnpm up iii-sdk@0.11.2) and npm (npm install iii-sdk@0.11.2) paths, with spinner labels and optional steps adjusted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nudged a pin where versions roam,
Locked iii-sdk to call it home.
No sneaky patches hopping through,
Routes stay steady, old and new.
A tidy hop — 0.11.2.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: pinning iii-sdk to version 0.11.2 to resolve a routing issue.
Linked Issues check ✅ Passed The PR fully addresses the requirements from issue #555 by pinning iii-sdk to exact version 0.11.2 in both package.json and CLI installation flow.
Out of Scope Changes check ✅ Passed All changes are directly related to pinning iii-sdk as required by issue #555; no out-of-scope modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pin-iii-sdk-0.11.2

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Source labels should describe what the code does, not point at issues
that rot as the codebase evolves. Issue context lives in the PR body.
@rohitg00
rohitg00 merged commit 93d1bdd into main May 20, 2026
6 of 7 checks passed
@rohitg00
rohitg00 deleted the fix/pin-iii-sdk-0.11.2 branch May 20, 2026 15:23
rohitg00 added a commit that referenced this pull request May 21, 2026
…uard (#588)

Three concerns surfaced when auditing PRs merged since v0.9.21:

1) Graph parser regex from #494 was correct for self-closing tags ONLY
   when they're the only entity in the document. With a self-closing
   entity followed by an explicit-close entity, the greedy `[^>]*` ate
   the trailing `/` of the self-close, the alternation fell through to
   the explicit-close branch, and `[\s\S]*?` ran ahead to the *next*
   `</entity>` — merging two entity declarations into one match and
   silently dropping a node. Switch to lazy `[^>]*?` so the
   self-closing alternation gets first chance. Test from #494 (which
   was failing on main but I didn't notice) now passes.

2) #386 shipped `${AGENTMEMORY_URL}` / `${AGENTMEMORY_SECRET}`
   placeholders in plugin/.mcp.json. Claude Code and Cursor expand
   those at MCP launch time; some hosts pass the literal string
   through. A truthy literal `"${AGENTMEMORY_URL}"` defeats the
   existing `|| DEFAULT_URL` fallback and would have the shim POST to
   `${AGENTMEMORY_URL}/agentmemory/...` (DNS failure). Add a
   defensive guard in src/mcp/rest-proxy.ts that strips any value of
   the form `${...}` so the fallback engages. Mirror in
   src/mcp/standalone.ts's mode-announce log line.

3) CHANGELOG entries for all PRs landed since v0.9.21 (#321, #325,
   #386, #454, #494, #526, #542, #560, #561, #562, #564, #567) plus
   the regex + env-guard hardening here.

Validation:
- npm test → 98 files, 1091 tests pass
- npm pack → 142 files, fresh install clean, iii-sdk@0.11.2 pinned,
  plugin/ shipped with hooks/scripts/skills/opencode/
- New test file covers 8 placeholder cases (unset, empty,
  `${VAR}` literal, mismatched braces, real values with $,
  unclosed `${`, no-braces `$VAR`).
healdigital pushed a commit to healdigital/agentmemory that referenced this pull request Jul 27, 2026
* fix(deps): pin iii-sdk to 0.11.2 to avoid routing regression in 0.11.6

iii-sdk@0.11.6 changes nested behavior so that all /agentmemory/* routes
return 404 against the iii-engine, even though both packages still
satisfy the previous "^0.11.2" semver range. npm picked up the new
version on `npm install -g @agentmemory/agentmemory` after 0.9.21
shipped, silently breaking installs.

Two pin sites:

1. package.json — caret -> exact "0.11.2" so npm cannot drift forward
   on minor releases until the upstream regression is sorted.

2. src/cli.ts — `agentmemory setup` previously ran
   `pnpm up iii-sdk@latest` / `npm install iii-sdk@latest`, which would
   re-pull 0.11.6+ even after a freshly-pinned install. Both call sites
   now pin to 0.11.2 with a label referencing this issue.

Tests (1081) + build pass against iii-sdk@0.11.2.

Closes rohitg00#555.

* fix(cli): drop issue ref from iii-sdk pin label

Source labels should describe what the code does, not point at issues
that rot as the codebase evolves. Issue context lives in the PR body.
healdigital pushed a commit to healdigital/agentmemory that referenced this pull request Jul 27, 2026
…uard (rohitg00#588)

Three concerns surfaced when auditing PRs merged since v0.9.21:

1) Graph parser regex from rohitg00#494 was correct for self-closing tags ONLY
   when they're the only entity in the document. With a self-closing
   entity followed by an explicit-close entity, the greedy `[^>]*` ate
   the trailing `/` of the self-close, the alternation fell through to
   the explicit-close branch, and `[\s\S]*?` ran ahead to the *next*
   `</entity>` — merging two entity declarations into one match and
   silently dropping a node. Switch to lazy `[^>]*?` so the
   self-closing alternation gets first chance. Test from rohitg00#494 (which
   was failing on main but I didn't notice) now passes.

2) rohitg00#386 shipped `${AGENTMEMORY_URL}` / `${AGENTMEMORY_SECRET}`
   placeholders in plugin/.mcp.json. Claude Code and Cursor expand
   those at MCP launch time; some hosts pass the literal string
   through. A truthy literal `"${AGENTMEMORY_URL}"` defeats the
   existing `|| DEFAULT_URL` fallback and would have the shim POST to
   `${AGENTMEMORY_URL}/agentmemory/...` (DNS failure). Add a
   defensive guard in src/mcp/rest-proxy.ts that strips any value of
   the form `${...}` so the fallback engages. Mirror in
   src/mcp/standalone.ts's mode-announce log line.

3) CHANGELOG entries for all PRs landed since v0.9.21 (rohitg00#321, rohitg00#325,
   rohitg00#386, rohitg00#454, rohitg00#494, rohitg00#526, rohitg00#542, rohitg00#560, rohitg00#561, rohitg00#562, rohitg00#564, rohitg00#567) plus
   the regex + env-guard hardening here.

Validation:
- npm test → 98 files, 1091 tests pass
- npm pack → 142 files, fresh install clean, iii-sdk@0.11.2 pinned,
  plugin/ shipped with hooks/scripts/skills/opencode/
- New test file covers 8 placeholder cases (unset, empty,
  `${VAR}` literal, mismatched braces, real values with $,
  unclosed `${`, no-braces `$VAR`).

This branch was successfully deployed

1 active deployment
Preview — f6bc271c Deployed May 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iii-sdk@0.11.6 breaks routing — nested dependency needs pin

1 participant