Repository navigation
Conversation
|
@mturac is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughNormalize LLM output to extract a ChangesSummary Parsing and Retry Resilience
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/functions/summarize.ts`:
- Around line 113-133: Wrap the provider.summarize call inside the retry loop in
a try/catch so transient provider errors are retried like in
summarizeChunkWithRetry; on catch, log a warning including the error plus
context.sessionId, attempt, context.mode and context.chunks, then continue to
the next attempt, and if all attempts fail rethrow the last caught error (or
propagate it) so callers see a final failure only after retries; keep
parseSummaryXml usage unchanged and return response immediately on successful
parse.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1eab56f5-9065-4582-948e-d594dee6be26
📒 Files selected for processing (2)
src/functions/summarize.tstest/summarize.test.ts
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/summarize.test.ts (1)
236-238: 💤 Low valueConsider using a more specific type for the
callsarray.The
callsproperty is typed asany[], whereas themakeProviderhelper function at lines 87-89 uses the more specificArray<{ system: string; user: string }>. Using the specific type would improve type safety and maintain consistency with other test helpers.♻️ Optional type improvement
- const provider: MemoryProvider & { calls: any[] } = { + const provider: MemoryProvider & { calls: Array<{ system: string; user: string }> } = { name: "test", calls: [],🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/summarize.test.ts` around lines 236 - 238, The provider stub declares calls as any[]; change it to the specific shape used by makeProvider to improve type safety by typing calls as Array<{ system: string; user: string }>. Locate the provider object (typed MemoryProvider & { calls: any[] }) in this test and replace the any[] with the more specific Array<{ system: string; user: string }>, ensuring any code that pushes or reads from provider.calls matches that structure.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/summarize.test.ts`:
- Around line 236-238: The provider stub declares calls as any[]; change it to
the specific shape used by makeProvider to improve type safety by typing calls
as Array<{ system: string; user: string }>. Locate the provider object (typed
MemoryProvider & { calls: any[] }) in this test and replace the any[] with the
more specific Array<{ system: string; user: string }>, ensuring any code that
pushes or reads from provider.calls matches that structure.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 90b891c6-141a-4ed3-b987-d5e8acca0561
📒 Files selected for processing (2)
src/functions/summarize.tstest/summarize.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- src/functions/summarize.ts
|
Thanks @mturac — fenced summary XML recovery shipped in v0.9.25 (PR #791 + release notes). Implementation matches your approach (strip markdown fences + retry final parse). Closing because the fix is on main. |
Fixes #783.
Summary:
Validation:
Summary by CodeRabbit
Bug Fixes
Tests