Use prepend to patch Action Cable classes#310
Conversation
143767a to
41a772a
Compare
|
bump! we are seeing this issue too |
|
We're able to reproduce this as well. Good fix! |
|
Yes, this issue still makes Lograge incompatible with AnyCable; we're currently using this patch. |
|
Bump! Now using a patched version of lograge to work around this. Thanks @palkan! |
|
@palkan could you rebase this on master so CI can run? Can you add an entry to the changelog for this too? Would love to get this merged in. |
41a772a to
103d827
Compare
|
We are seeing builds failing now since we pinned to commit |
Oops, sorry 🙄 (Highly recommend to fork all source-based dependencies to avoid such problems in the future) |
To preserve the original functionality a better monkey-patching technique than copying the code should be used, e.g., Module#prepend Fixes roidrage#304
103d827 to
2c1a849
Compare
|
@palkan Awesome change! Mind submitting another PR with a changelog entry? Hoping to cut a new release soon. |
To preserve the original functionality a better monkey-patching technique than copying the code should be used, e.g.,
Module#prepend.NOTE: The original Action Cable code for Connection class has been already changed, thus Lograge breaks the core functionality:
Fixes #304.
Related to #294.