Fixed broken package.json, updated all deps and react example#115
Merged
Conversation
matux
force-pushed
the
matux/fix-package-json
branch
from
04aa540 to
fd475bc
Compare
matux
force-pushed
the
matux/fix-package-json
branch
from
8f387c0 to
3c32082
Compare
mudetroit
approved these changes
Feb 29, 2024
Contributor
mudetroit
left a comment
mudetroit
left a comment
There was a problem hiding this comment.
Only one small note here. If you want to push that work to another PR I am okay with that as well
Comment on lines
+20
to
+26
| rules: | ||
| indent: [error, 2] | ||
| quotes: | ||
| - error | ||
| - single | ||
| - avoidEscape: true | ||
| allowTemplateLiterals: true |
Contributor
There was a problem hiding this comment.
Preference
9/10
Instead of putting formatting rules in eslint use prettier to check formatting. Use eslint-config-prettier. That way we don't end up in a situation where they conflict with one another.
Collaborator
Author
There was a problem hiding this comment.
Sounds great to me. This was like this when I moved it (I just reordered it so the overrides were left at the bottom).
I'll do it in a separate PR to keep things as tidy as possible!
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vast majority of line changes come from package-lock.
Description of the change
This PR fixes some
package.jsondiscrepancies that were causingnpm installto fail.The main discrepancy was in the versions declared for react (16.x) and react-dom (17.x). Once this was fixed, a few other deps needed adjustment.
In the end, they were all updated to their latest React 17-supporting versions.
React version on
peerDependenciesremains untouched, ranging from 16 to 18.The version of Typescript has also been bumped from 4 to 5. Although the source code is pure js.
eslintandprettierwere also updated to their latest versions, these updates required that the rollup config js file be renamed to mjs due to its use of modules, and some minimal updates to the eslint config.The
.tools-versionsfile which declared node 14 has been removed, the project should be able to be npm installed and built using any LTS node beginning in 14, something the ci checks already since the recent changes.Type of change
Checklists
Development
Code review