Skip to content

fix: Add typings to Provider#27

Merged
waltjones merged 1 commit into
rollbar:mainfrom
quinnturner:typing-provider
Jan 25, 2022
Merged

fix: Add typings to Provider#27
waltjones merged 1 commit into
rollbar:mainfrom
quinnturner:typing-provider

Conversation

@quinnturner
Copy link
Copy Markdown
Contributor

Description of the change

Adds TypeScript types to Provider

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Related: #26 (comment)

@quinnturner quinnturner mentioned this pull request Jan 25, 2022
12 tasks
@calvinf
Copy link
Copy Markdown

calvinf commented Jan 25, 2022

Brilliant. LGTM.

Copy link
Copy Markdown
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@waltjones waltjones merged commit bb926a4 into rollbar:main Jan 25, 2022
@calvinf
Copy link
Copy Markdown

calvinf commented Jan 25, 2022

@waltjones you are a hero, thank you!
@quinnturner you are a hero, thank you!

@quinnturner quinnturner deleted the typing-provider branch January 25, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants