Fix declaration of unique symbols#52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
The Typescript declaration file was importing several unique symbols (
RollbarInstance, BaseOptions, RollbarCtor) to be used in a type definition, but the path for these doesn't exist in the release package, breaking the import path.To fix this, the import can be removed completely since only a declaration of a unique symbol is needed, not the actual value.
This PR also fixes an issue where a constant (
Context) was used instead of the correct type (ReactContext<ContextInterface>).Note: "unexpected any" CI warnings are expected, and not related to the PR.
Type of change
Related issues
Fixes: #48
Development
Code review