Multiple uses of StyleSheet in NativewindUI App and use of non-tailwind styles, hardcoded colors

[NomadNiko]

TabBarIcon, ScreenContent, HeaderButton, EditScreenInfo, Container, RN Button, BackButton, two, all using StyleSheet.create rather than utilizing nativewind/tailwindcss styles. Suggest moving all styles to tailwindcss and removing SyleSheet usage entirely.

_layout.tsx is using hardcoded black color for the selected tab font color, which doesnt look good in Dark Mode. Suggest using useColorScheme foreground text color (Black in Light Mode, White in Dark Mode).

I have already fixed these all in my local and will be submitting a pull request to clean these up later today after my vampiric sleep cycle.

[NomadNiko]

@danstepanov @dannyhw its taking me a little longer because it looks like nativewind and nativewindui share some files as a part of your ejs way of building things, so I'm needing to also roll out the changes to the nativewind template. Should have my proposed PR over by tomorrow. I've never worked with ejs so I'm just being extra careful.

[NomadNiko]

Aloha guys, just wondering if any of this conditional logic in the +not-found.tsx.ejs files for Drawers and Tabs options are needed in the nativewindui templates, since it appears from configureProjectFiles.ts that the files in packages/nativewindui will only ever apply to that stylingPackage. (also, the +not-found.tsx.ejs within packages\nativewindui\stack\app does not have this conditional logic)
Can I clean this up as part of my refactor?
example:

import { Link, Stack } from 'expo-router';
<% if (props.stylingPackage?.name === "nativewind") {%>
  import { Text, View } from 'react-native';
<% } else if (props.stylingPackage?.name === "nativewindui") {%>
  import { View } from 'react-native';
  
  import { Text } from '~/components/nativewindui/Text';
<% } else if (props.stylingPackage?.name === "unistyles") { %>
  import { createStyleSheet, useStyles } from 'react-native-unistyles'
  import { Text, View } from 'react-native';
<% } else if (props.stylingPackage?.name === "stylesheet") { %>
  import { StyleSheet, Text, View } from 'react-native';
<% } else if (props.stylingPackage?.name === "tamagui") { %>
  import { YStack } from "tamagui";
	import { Container, Main, Subtitle, Title } from "../tamagui.config";
<% } else if (props.stylingPackage?.name === "restyle") { %>
  import { Box, Text, makeStyles } from 'theme';
<% } %>

[NomadNiko]

Seems to me like that logic should possibly roll up to expo-routers +not-found in case you ever have it be the base for the nativewindui templates, and the template specific files should be more like src/templates/packages/nativewindui/stack/app/+not-found.tsx.ejs

[dannyhw]

you're probably correct, i think best thing is to just make the pr with your suggested solution and we can see what you mean.