Conversation
Pull Request Test Coverage Report for Build 13585994050Details
💛 - Coveralls |
…defaults, use coveralls-action for conda coverage, group dependabot updates
|
@cehbrecht I'm going to continue organizing this PR so that we can at least receive automated updates. This should make the management of the library a bit simpler. The next step will be to pull out |
|
@Zeitsperre could we also add pytest-xdist to run tests in parallel? |
|
@cehbrecht Possibly! If the tests are written to handle it, I think it shouldn't be an issue. I'll test it locally. |
…oders.CFDatetimeCoder(use_cftime=True)`
|
@cehbrecht This is ready to go. Should I wait for #397 before merging this? Also, FYI, the |
added Martin
| * The `LICENSE` file has been adjusted to ensure it is more machine-parsable (#398). | ||
| * Licensing information has been added to the top-level `__init__.py` file of the package (#398). | ||
| * The `README.rst` file has been updated to include a table of relevant badges (#398). | ||
| * All calls using `use_cftime=True` have been updated to `decode_times=xr.coders.CFDatetimeCoder(use_cftime=True)` as suggested by `xarray` (#398). |
There was a problem hiding this comment.
do you have a link to the xarray docs for this?
There was a problem hiding this comment.
@Zeitsperre looks good. thanks :) you can merge this before the other PR #397 |
Pull Request Checklist:
What kind of change does this PR introduce?:
README.rstto use a table of badges and added some relevant badges.psy-maps(should be addressed in the future; see below).use_cftimecalls todecode_times=xr.coders.CFDatetimeCoder(use_cftime=True), as is suggested byxarray.xarrayandnumpy(failures with specific types of data need to be fixed upstream).Does this PR introduce a breaking change?:
Yes:
psy-mapis no longer installed via thecondaenvironment, but is instead patched into the ReadTheDocs environment when building the docs. Ideally, we should remove the code-blocks using this (are there alternatives available?).CIdirectory in the top-level. This makes it easier for Dependabot to perform updates on these libraries. They are installed via commit hashes for added security.cf-time/cf-xarrayissues are now marked asxfail.Other information:
The
use_cftimekeyword arg has been deprecated as ofxarrayv2025.01.1 (https://docs.xarray.dev/en/stable/generated/xarray.open_dataset.html).It looks like the
psy-mapslibrary is no longer maintained and the package metadata only lists support for version until Python3.10! There is a need to remove this library if we want to build documentation on newer Python versions.There's also a need to lift the pin on
xarray. I know that we have some outstanding issues related tocf-time/cf-xarraythat need to be dealt with for that to happen. Relevant issue/PR: