Replace ConcatFileName with PrependPathName#18859
Merged
guitargeek merged 13 commits intoroot-project:masterfrom Nov 28, 2025
Merged
Conversation
FabioGhattasPolimi
requested review from
bellenot,
dpiparo,
guitargeek,
lmoneta and
pcanal
as code owners
pcanal
reviewed
May 23, 2025
pcanal
reviewed
May 23, 2025
pcanal
reviewed
May 23, 2025
pcanal
reviewed
May 23, 2025
pcanal
reviewed
May 23, 2025
pcanal
reviewed
May 23, 2025
pcanal
reviewed
May 23, 2025
dpiparo
changed the title
Member
|
As a side node which OS and compiler are you using to locally test that the code compiled and the test suite passes? |
Contributor
Author
|
Windows, using Visual Studio 17 2022 |
Test Results 2 files 2 suites 7h 8m 6s ⏱️ Results for commit 64eff83. |
pcanal
reviewed
May 27, 2025
pcanal
reviewed
May 27, 2025
pcanal
reviewed
May 27, 2025
pcanal
reviewed
May 27, 2025
…TGTextEditor, TRootBrowserLite and TGuiBldDragManager
…ProofLite, RooWorkspace and TChainParsing
Co-authored-by: Philippe Canal <[email protected]>
guitargeek
force-pushed
the
Replace-ConcatFileName-with-PrependPathName-18754
branch
2 times, most recently
from
bc75765 to
94562d2
Compare
guitargeek
force-pushed
the
Replace-ConcatFileName-with-PrependPathName-18754
branch
from
94562d2 to
a360f66
Compare
Contributor
|
Just had to fix a typo |
hageboeck
added a commit
to hageboeck/root
that referenced
this pull request
Jan 9, 2026
Since roottest-root-io-newstl-nolib is marked WILLFAIL, it was not noticed in root-project#18859 that e60640c introduced a function that does not exist. The test still fails, but that's a different issue to be investigated.
hageboeck
added a commit
to hageboeck/root
that referenced
this pull request
Jan 12, 2026
Since roottest-root-io-newstl-nolib is marked WILLFAIL, it was not noticed in root-project#18859 that e60640c introduced a function that does not exist. The test still fails, but that's a different issue to be investigated.
hageboeck
added a commit
that referenced
this pull request
Jan 13, 2026
Since roottest-root-io-newstl-nolib is marked WILLFAIL, it was not noticed in #18859 that e60640c introduced a function that does not exist. The test still fails, but that's a different issue to be investigated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Replaced TSystem::ConcatFileName with TSystem::PrependPathName in all the root project
Checklist:
This PR fixes #18754