[636] Fix Chi2Test: Support residuals for 2D/3D histograms (#20798) #20844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) [hist] Chi2Test: Support residuals for 2D/3D histograms Fixed bug where Chi2Test only stored residuals for 1D histograms. For 2D/3D histograms, the residual array indexing ignored j and k loop indices, causing incorrect storage. Added resIndex counter for each comparison mode (UU, UW, WW) to properly index the residuals array for multi-dimensional histograms. Fixes root-project#20761 (cherry picked from commit 5b770f8)
Test Results 17 files 17 suites 2d 19h 19m 7s ⏱️ For more details on these failures, see this check. Results for commit f00eaf4. |
dpiparo
merged commit b4fd093
into
root-project:v6-36-00-patches
18 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[hist] Chi2Test: Support residuals for 2D/3D histograms
Fixed bug where Chi2Test only stored residuals for 1D histograms. For 2D/3D histograms, the residual array indexing ignored j and k loop indices, causing incorrect storage.
Added resIndex counter for each comparison mode (UU, UW, WW) to properly index the residuals array for multi-dimensional histograms.
Fixes #20761
(cherry picked from commit 5b770f8)