[CPyCppyy] Add back the (U)Long64_t converters and executors#20895
Merged
guitargeek merged 2 commits intoroot-project:masterfrom Jan 15, 2026
Merged
[CPyCppyy] Add back the (U)Long64_t converters and executors#20895guitargeek merged 2 commits intoroot-project:masterfrom
(U)Long64_t converters and executors#20895guitargeek merged 2 commits intoroot-project:masterfrom
Conversation
vepadulano
approved these changes
Jan 15, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
I agree with the changes, we need them until we move cppyy to using CppInterop. Please merge only once the CI is green.
…nize.cxx" This reverts commit d8593cb.
We always need the `(U)Long64_t` converters and executors when cppyy is based on an unpatched ROOT, because the "long long" types are always converted to `Long64_t` and `ULong64_t` already at the ROOT Meta level. So this is what cppyy will see even when using `long long` types. This partially reverts 8d2a6df. See root-project#15872 (comment) Closes root-project#15872. The change means that we can also run a few more `cppyy` unit tests on Windows 64 bits, even though they still need to be marked as `xfail` as they still fail for other reasons.
guitargeek
force-pushed
the
issue-15872
branch
from
9577b7e to
ddfb27b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We always need the
(U)Long64_tconverters and executors when cppyy isbased on an unpatched ROOT, because the "long long" types are always
converted to
Long64_tandULong64_talready at the ROOT Meta level.So this is what cppyy will see even when using
long longtypes.This partially reverts 8d2a6df.
See #15872 (comment)
Closes #15872.
The change means that we can also run a few more
cppyyunit tests onWindows 64 bits, even though they still need to be marked as
xfailas they still fail for other reasons.
The temporary workaround d8593cb is also reverted, as the reason for
std::vector::reserve()not being callable was that it usedunsigned long longas the parameter type on Windows 64 bit.