Remove unnecessary linking to component_manager. #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These libraries are components themselves, and never need any parts of component_manager. So just remove this dependency. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Contributor
|
Thanks!
Done! |
Contributor
Author
|
Thanks, much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These libraries are components themselves, and never need any parts of component_manager. So just remove this dependency.
@mintar This is a follow-up to #191 (apologies that I did not respond at the time you opened it).
On a separate but related note, given that Noetic is now End-of-Life, would you mind if we made the default branch for this repository
rolling?