Skip to content

Add kr6 r900-2 support#198

Merged
simonschmeisser merged 5 commits into
ros-industrial:melodic-develfrom
isys-vision:add_kr6_900-2
Sep 29, 2021
Merged

Add kr6 r900-2 support#198
simonschmeisser merged 5 commits into
ros-industrial:melodic-develfrom
isys-vision:add_kr6_900-2

Conversation

@cjue

@cjue cjue commented Sep 22, 2021

Copy link
Copy Markdown
Contributor

reuses identical kr10 r900-2 meshes

@gavanderhoorn gavanderhoorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as this seems to reuse meshes in another package, we should state that dependency in the manifest.

Note reuse of kuka_kr10_support meshes
@cjue

cjue commented Sep 22, 2021

Copy link
Copy Markdown
Contributor Author

I added an exec_depend and amended the description in the manifest.

@gavanderhoorn

Copy link
Copy Markdown
Member

@simonschmeisser: will you review this one?

@simonschmeisser simonschmeisser left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repeating mostly review comments @gavanderhoorn made yesterday on #162

Comment thread kuka_kr6_support/urdf/kr6r900_2_macro.xacro Outdated
Comment thread kuka_kr6_support/urdf/kr6r900_2_macro.xacro Outdated
Comment thread kuka_kr6_support/urdf/kr6r900_2_macro.xacro Outdated
Comment thread kuka_kr6_support/CMakeLists.txt Outdated
@cjue

cjue commented Sep 23, 2021

Copy link
Copy Markdown
Contributor Author

pushed a commit adressing the requests

Comment thread kuka_kr6_support/urdf/kr6r900_2_macro.xacro Outdated
Comment thread kuka_kr6_support/urdf/kr6r900_2_macro.xacro Outdated
@cjue

cjue commented Sep 23, 2021

Copy link
Copy Markdown
Contributor Author

removed duplilcate tool0

@simonschmeisser simonschmeisser changed the base branch from indigo-devel to melodic-devel September 23, 2021 14:47
@simonschmeisser

Copy link
Copy Markdown
Collaborator

@gavanderhoorn super friendly ping :)

@gavanderhoorn gavanderhoorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Looks good.

And thanks for iterating.

Note: I've not tested this model/variant extensively. I'm trusting you have done that before submitting this PR.

@simonschmeisser

Copy link
Copy Markdown
Collaborator

@simonschmeisser simonschmeisser merged commit b4b53f4 into ros-industrial:melodic-devel Sep 29, 2021
@gavanderhoorn gavanderhoorn mentioned this pull request Oct 21, 2021
kriegljan pushed a commit to kriegljan/kuka_experimental that referenced this pull request Nov 18, 2021
* Add KR 6 R900-2 support

Note reuse of kuka_kr10_support meshes
kriegljan pushed a commit to kriegljan/kuka_experimental that referenced this pull request Nov 18, 2021
* Add KR 6 R900-2 support

Note reuse of kuka_kr10_support meshes
@cjue cjue deleted the add_kr6_900-2 branch April 4, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants