Fix the behavior of get_kerning to match FreeType's behavior#203
Open
ExplodingBottle wants to merge 2 commits intorougier:masterfrom
Open
Fix the behavior of get_kerning to match FreeType's behavior#203ExplodingBottle wants to merge 2 commits intorougier:masterfrom
ExplodingBottle wants to merge 2 commits intorougier:masterfrom
Conversation
Collaborator
|
I am somewhat against merging this, but I shall give a better answer when I look at the code in detail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #202 by changing the behavior of
Face.get_kerningto match the one of FreeType (this is done by removing the calls toget_char_index) and also updates the examples accordingly.The documentation has been left untouched.