Repository navigation
fix(ui,sessions,usage): reset tab scroll, support direct session deletion, and show token counts in usage breakdowns - #541
Open
jianli9158 wants to merge 1 commit into
Conversation
…tion, and show token counts in usage breakdowns
Contributor
|
This pull request targeted The base branch has been automatically changed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves three high-priority UX and functionality issues (#534, #540, and #511):
Reset scroll position across tab and subpage transitions (Fixes Scroll position persists across tab changes, leaving non-scrollable views cut off #534)
resetWorkspaceScroll()insrc/navigation.tsand invokes it across top-level page transitions (src/App.tsx) and subpage tab changes (src/pages/ConfigPanel.tsx,src/pages/ManagementPages.tsx)..immersive-window,.window-content,.app-shell,document.documentElement,document.body) after setting-searchscrollIntoView()calls so non-scrollable views are never stuck at an inherited vertical offset.Constrain Codex session delete dialog height & support permanent deletion without backup (Fixes 会话删除 #540)
.codex-session-dialogheight (max-height: min(560px, calc(100vh - 40px))) and makes long session descriptions vertically scrollable (max-height: min(240px, calc(100vh - 250px)); overflow-y: auto), keeping the confirmation actions visible inside the viewport even for multi-paragraph session titles.skipBackupflag toDeleteCodexSessionsRequest(src-tauri/src/codex_sessions.rs,src/services/codexSessions.ts, andsrc/mocks/browserMockRuntime.ts) and a Delete directly without creating a backup checkbox insrc/pages/CodexSessionsPanel.tsx(localized acrossen,zh-CN,zh-TW, andja).Display token usage alongside request counts in Usage Analysis breakdowns (Fixes 分析统计使用情况，改版后按密钥统计列表只有调用次数，没有token #511)
CategorySummaryinsrc/pages/UsageAnalysisView.tsxandsrc/pages/UsageAnalysisView.cssso both the summary caption and expanded list rows for Source and Key display token consumption ({tokens} Token) alongside request counts.Verification
bun run check(tsc --noEmit) passes with zero errors.bun test tests/navigationAndUpdate.test.ts tests/i18n.test.ts tests/binaryControls.test.tsx tests/surfaceControls.test.ts tests/cssSyntax.test.ts tests/browserMockRuntime.test.tspasses.Advanced Features -> Quota / Homescroll transitions,Usage -> Analysissource/key breakdowns, andAgent Configuration -> Codex -> Session Managementdelete confirmation modal with long session titles.