Bugfix/266 load path access type (#274)

* Fix bug in `pins.drivers.load_path`

* Add tests.

* Update pins/drivers.py

Co-authored-by: Isabel Zimmerman <54685329+isabelizimm@users.noreply.github.com>

* Update pins/drivers.py

Co-authored-by: Isabel Zimmerman <54685329+isabelizimm@users.noreply.github.com>

* Update pins/drivers.py

Co-authored-by: Isabel Zimmerman <54685329+isabelizimm@users.noreply.github.com>

* Add missing `from __future__ import annotations`

---------

Co-authored-by: Isabel Zimmerman <54685329+isabelizimm@users.noreply.github.com>

Author: nathanjmcdougall

pins/drivers.py

@@ -25,12 +25,15 @@ def _assert_is_pandas_df(x, file_type: str) -> None:
 def load_path(meta, path_to_version):
     # Check that only a single file name was given
     fnames = [meta.file] if isinstance(meta.file, str) else meta.file
-    if len(fnames) > 1 and type in REQUIRES_SINGLE_FILE:
+
+    _type = meta.type
+
+    if len(fnames) > 1 and _type in REQUIRES_SINGLE_FILE:
         raise ValueError("Cannot load data when more than 1 file")
 
     # file path creation ------------------------------------------------------
 
-    if type == "table":  # noqa: E721 False Positive due to bug: https://github.com/rstudio/pins-python/issues/266
+    if _type == "table":
         # this type contains an rds and csv files named data.{ext}, so we match
         # R pins behavior and hardcode the name
         target_fname = "data.csv"

pins/tests/test_drivers.py

@@ -1,11 +1,13 @@
+from __future__ import annotations
+
 from pathlib import Path
 
 import fsspec
 import pandas as pd
 import pytest
 
 from pins.config import PINS_ENV_INSECURE_READ
-from pins.drivers import default_title, load_data, save_data
+from pins.drivers import default_title, load_data, load_path, save_data
 from pins.errors import PinsInsecureReadError
 from pins.meta import MetaRaw
 from pins.tests.helpers import rm_env
@@ -159,3 +161,34 @@ def test_driver_apply_suffix_false(tmp_path: Path):
     res_fname = save_data(df, p_obj, type_, apply_suffix=False)
 
     assert Path(res_fname).name == "some_df"
+
+
+class TestLoadFile:
+    def test_multi_file_raises(self):
+        class _MockMetaMultiFile:
+            file: str | list[str] = ["a", "b"]
+            type: str = "csv"
+
+        with pytest.raises(ValueError, match="Cannot load data when more than 1 file"):
+            load_path(_MockMetaMultiFile(), None)
+
+    def test_str_file(self):
+        class _MockMetaStrFile:
+            file: str = "a"
+            type: str = "csv"
+
+        assert load_path(_MockMetaStrFile(), None) == "a"
+
+    def test_table(self):
+        class _MockMetaTable:
+            file: str = "a"
+            type: str = "table"
+
+        assert load_path(_MockMetaTable(), None) == "data.csv"
+
+    def test_version(self):
+        class _MockMetaTable:
+            file: str = "a"
+            type: str = "csv"
+
+        assert load_path(_MockMetaTable(), "v1") == "v1/a"