Skip to content

Conversation

@nathanjmcdougall
Copy link
Contributor

To fix #266.

@nathanjmcdougall
Copy link
Contributor Author

I realize that in my tests, I am mocking using a restricted Meta protocol similar to what is described in #12:

Alternatively, there could be a stripped down version for Meta (or an interface), that defines the bare minimum required for data loading (i.e. type, filename).

This might be an opportunity to formally define a Protocol class and refactor the test suite accordingly.

@nathanjmcdougall nathanjmcdougall force-pushed the bugfix/266-load_path-access-type branch from 0f149c7 to 37c7486 Compare July 25, 2024 08:11
Copy link
Collaborator

@isabelizimm isabelizimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small naming nit, but otherwise looks good! Thank you for the tests as well 🙌

@nathanjmcdougall nathanjmcdougall force-pushed the bugfix/266-load_path-access-type branch from cd63988 to 8ff41c3 Compare August 20, 2024 21:52
@isabelizimm isabelizimm merged commit 3c0fbb7 into rstudio:main Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: pins.drivers.load_path function uses built-in type

2 participants