feat: add board_connect for Posit Connect, formerly RStudio#173
Merged
Conversation
Collaborator
Author
|
cc @juliasilge in case there's anything useful I missed (these changes are merged, but it's not released yet) |
Member
|
@machow it looks like we still need to make updates in:
|
Collaborator
Author
|
@juliasilge thanks for catching! I think the first two make a lot of sense, but wonder if we shouldn't change the last one, since it breaks backwards compatibility? It assumes that all users will have the latest version of pins installed? Happy to do w/e seems useful though! (Could also see adding a comment to explain that the name changed) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(WIP) Addresses #172