Skip to content

fix: close open file handles in pin_download #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isabelizimm merged 1 commit into from
Aug 15, 2023
Merged

fix: close open file handles in pin_download #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions pins/boards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,17 +388,16 @@ def pin_download(self, name, version=None, hash=None) -> Sequence[str]:

# TODO: raise for multiple files
# fetch file
f = load_file(
with load_file(
meta, self.fs, self.construct_path([pin_name, meta.version.version])
)
) as f:
# could also check whether f isinstance of PinCache
fname = getattr(f, "name", None)

# could also check whether f isinstance of PinCache
fname = getattr(f, "name", None)
if fname is None:
raise PinsError("pin_download requires a cache.")

if fname is None:
raise PinsError("pin_download requires a cache.")

return [str(Path(fname).absolute())]
return [str(Path(fname).absolute())]

def pin_upload(
self,
Expand Down