Allow writing pins in multiple formats#877
Conversation
9679f5c to
b8717d1
Compare
|
Was there more you wanted to do here before a review, @lbm364dl? I notice it is still draft. |
Yes, my intention was to address this thing I mentioned in the linked issue:
I didn't have time to look into that. But it should be independent anyway. I can try in another PR. What is present here should already be enough to close the issue. A review is more than welcome. |
juliasilge
left a comment
There was a problem hiding this comment.
I kind of wonder if we should just error and refuse to read if people try to read without type for a pin with multiple types, but we can try this out and see how people experience it.
Thanks for this contribution, @lbm364dl!
| pin_write(board, mtcars, name = "mtcars", type = "froopy-loops") | ||
| Condition | ||
| Error in `object_write()`: | ||
| Error: |
There was a problem hiding this comment.
I couldn't get the call to work correctly in this case for the error, so we'll just go with this for now.
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Closes #788.
Allowing multiple types in
pin_writerequired some minor tweaks inpin_read. Instead of just choosing an arbitrary type from those available to read from, I also added atypeargument inpin_read.