Merged
Conversation
koic
force-pushed
the
ci_against_ruby_34
branch
3 times, most recently
from
cf01ff9 to
02a685a
Compare
Ruby 3.4 has been released, and support for Ruby 3.4.0 and 3.4.1 was added to setup-ruby: ruby/setup-ruby#679 rubocop/rubocop#13297 is required to pass the following spec on both Ruby versions before 3.3 and 3.4 and later: ```console 1) RuboCop::ConfigStore.for always uses config specified in command line Failure/Error: expect(config_store.for('file1')).to eq('merged {:options_config=>true}') expected: "merged {:options_config=>true}" got: "merged {options_config: true}" (compared using ==) # ./spec/rubocop/config_store_spec.rb:25:in 'block (3 levels) in <top (required)>' # tasks/spec_runner.rake:83:in 'RuboCop::SpecRunner::ParallelRunner#run_worker' # tasks/spec_runner.rake:38:in 'block in RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:52:in 'RuboCop::SpecRunner#with_encoding' # tasks/spec_runner.rake:36:in 'RuboCop::SpecRunner#run_specs' # tasks/spec_runner.rake:164:in 'block in <top (required)>' ``` https://github.com/rubocop/rubocop-ast/actions/runs/12529029565/job/34944210256 Therefore, RuboCop used in `rubocop_specs` has been updated to v1.69.2, the version released with Ruby 3.4.
koic
force-pushed
the
ci_against_ruby_34
branch
from
02a685a to
7816c35
Compare
Earlopain
reviewed
Dec 28, 2024
| include: | ||
| - { rubocop: master, ruby: "3.0", os: ubuntu } | ||
| - { rubocop: "v1.61.0", ruby: "3.3", os: ubuntu } | ||
| - { rubocop: "v1.69.2", ruby: "3.4", os: ubuntu } |
Contributor
There was a problem hiding this comment.
I guess, this is supposed to test that rubocop-ast still works with older rubocop? Would it then make more sense to instead test master against the latest ruby version so that this can be left with and older version?
Member
Author
There was a problem hiding this comment.
I don't have strong opinions about this, this PR aligns with the previous upgrade:
#274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 3.4 has been released, and support for Ruby 3.4.0 and 3.4.1 was added to setup-ruby: ruby/setup-ruby#679
rubocop/rubocop#13297 is required to pass the following spec on both Ruby versions before 3.3 and 3.4 and later:
https://github.com/rubocop/rubocop-ast/actions/runs/12529029565/job/34944210256
Therefore, RuboCop used in
rubocop_specshas been updated to v1.69.2, the version released with Ruby 3.4.