Render hyperlinks in docx documents as html anchor tags#70
Closed
ollieh-m wants to merge 4 commits into
Closed
Conversation
gopeter
added a commit
to gopeter/docx
that referenced
this pull request
Sep 14, 2020
satoryu
added a commit
that referenced
this pull request
Oct 14, 2020
Added support for hyperlinks (implemented #70 again)
Member
|
#92 including changes in this PR has been merged. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gem's been working great for a project. I've recently needed to start rendering hyperlinks contained in docx files as anchor tags in html output, so made this change on a forked version but thought I'd put in a pull request in case it's useful for others.
The hyperlink targets get stored in a separate rels file, so the first step after unzipping the document is to extract those targets from the correct file and store them ready to be used later. Then if a text run is a hyperlink element, the .to_html method inserts the stored target into the href attribute of an anchor tag.