add back message key in order to have error_codes

[mkou]

In my situation, in the exception validations, I need message keys as well as the translations in order to pass error codes

[dblock]

This needs tests and a CHANGELOG entry, please.

[mkou]

@dblock Done. Thanks for the feedback

[dblock]

Can I nitpick? Is this better? Avoids checking key? twice.

return unless args.key?(:message)
@message_key = args[:message] if args[:message].is_a?(Symbol)
args[:message] = translate_message(args[:message])

or with an if, I don't care.

[mkou]

Hmm wouldn't the return bypass the super method?
I like the idea of not checking the key twice though.

[mkou]

Would you prefer that version ?

super && return unless args.key?(:message)
@message_key = args[:message] if args[:message].is_a?(Symbol)
args[:message] = translate_message(args[:message])
super

or

if args.key?(:message)
  @message_key = args[:message] if args[:message].is_a?(Symbol)
  args[:message] = translate_message(args[:message])
end
super

(I think I prefer the last one)

[ridiculous]

definitely the latter 👍

[dblock]

likewise I'm with @ridiculous

[mkou]

Thanks! 😄 What do you think?

[dblock]

Merged squashed, thanks.