Fix Ruby 2.7 deprecation warning#2104
Merged
Merged
Conversation
Generated by 🚫 danger |
stanhu
force-pushed
the
sh-fix-ruby-2.7-kwargs
branch
from
13044ef to
6996194
Compare
dblock
approved these changes
Sep 28, 2020
dblock
left a comment
dblock
left a comment
Member
There was a problem hiding this comment.
Happy to merge on CHANGELOG + Green build, thank you.
dblock
reviewed
Sep 28, 2020
stanhu
force-pushed
the
sh-fix-ruby-2.7-kwargs
branch
from
6996194 to
f3d265c
Compare
Member
|
Rebase? |
This fixes the warning: ``` ruby/2.7.0/gems/grape-1.4.0/lib/grape/dsl/inside_route.rb: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call ``` More details: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
stanhu
force-pushed
the
sh-fix-ruby-2.7-kwargs
branch
from
f3d265c to
9b678f4
Compare
Contributor
Author
|
Done. |
Member
|
Before I merge, there are other similar deprecation warnings in the spec runs, want to fix those too? e.g. |
Member
|
I've merged this one for now. |
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the warning:
More details:
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/